git.postgresql.org Git - postgresql.git/log
Add last-vacuum/analyze-time columns to the stats collector, both manual and
issued by autovacuum. Add accessor functions to them, and use those in the
pg_stat_*_tables system views.
Catalog version bumped due to changes in the pgstat views and the pgstat file.
Patch from Larry Rosenman, minor improvements by me.
Call MarkBufferDirty() before XLogInsert() during completion of insert
Simplify gistSplit() and some refactoring related code.
Have autovacuum report its activities to the stat collector.
Fix typo in comment.
Fix Solaris/ASM test for x86.
Rework completion of incomplete inserts. Now it writes
WAL log during inserts.
Back out \' change for tsearch2, broke regression tests.
Mention packager bumps configure.in/configure.
Stamp 8.1.4, except configure/configure.in.
Update for version 8.1.4.
Update release notes for 8.1.4.
Use SQL standard '' rather than \' in /contrib. Backpatch to 8.1.X.
Use unsigned into for slock_t for pre-sparcv8plus.
Tom Lane [2006年5月18日 19:56:46 +0000 (19:56 +0000)]
Fix choose_bitmap_and() so that partial index predicates are considered when
deciding whether a potential additional indexscan is redundant or not. As now
coded, any use of a partial index that was already used in a previous AND arm
will be rejected as redundant. This might be overly restrictive, but not
considering the point at all is definitely bad, as per example in bug #2441
from Arjen van der Meijden. In particular, a clauseless scan of a partial
index was *never* considered redundant by the previous coding, and that's
surely wrong. Being more flexible would also require some consideration
of how not to double-count the index predicate's selectivity.
Tom Lane [2006年5月18日 18:57:31 +0000 (18:57 +0000)]
When a bitmap indexscan is using a partial index, it is necessary to include
the partial index predicate in the scan's "recheck condition". Otherwise,
if the scan becomes lossy for lack of bitmap memory, we would fail to enforce
that returned rows satisfy the predicate. Noted while studying bug #2441
from Arjen van der Meijden.
Allow sparcv8plus to use "cas".
Theo Schlossnagle
Code alignment fix.
Tom Lane [2006年5月18日 17:12:10 +0000 (17:12 +0000)]
Fix thinko in recent changes to handle ScalarArrayOpExpr as an indexable
condition: when there are multiple possible index paths involving
ScalarArrayOpExprs, they are logically to be ANDed together not ORed.
This thinko was a direct consequence of trying to put the processing
inside generate_bitmap_or_paths(), which I now see was a bit too cute.
So pull it out and make the callers do it separately (there are only two
that need it anyway). Partially responds to bug #2441 from Arjen van der Meijden.
There are some additional infelicities exposed by his example, but they
are also in 8.1.x, while this mistake is not.
Remove canonicalize_path() call for .pgpass socket directory comparison;
not worth adding path.c to libpq.
Mention that gcc/sparc generates sparcv7 binaries.
Change <type>string</> to <parameter>string</>.
Add:
>
> * Add a GUC to control whether BEGIN inside a transcation should abort
> the transaction.
Add more sparcv8plus comments.
Make function param_name/type documentation more consistent.
Add mention of -xarch=v8plus for "cas" usage on Solaris/sparc.
Add simplified sparc8 ASM for solaris_sparc.s, from Alan Stange.
Add comments that Solaris Sun compiler only supports sparc9 ASM,
Change spaces to tabs, for consistency. (Caused by email cut/paste.)
Allow the .pgpass hostname to match the default socket directory, as
well as a blank pghost.
Change catalog version due to WAL protocol changes in GiST
Reduce size of critial section during vacuum full, critical
sections now isn't nested. All user-defined functions now is
called outside critsections. Small improvements in WAL
protocol.
TODO: improve XLOG replay
Rename macro parameter, for clarity.
Update pg_dump vesion wording.
Mention version portability of pg_dump.
Tom Lane [2006年5月12日 22:44:36 +0000 (22:44 +0000)]
Fix the sense of the test on DH_check()'s return value. This was preventing
custom-generated DH parameters from actually being used by the server.
Found by Michael Fuhr.
Tom Lane [2006年5月12日 16:50:52 +0000 (16:50 +0000)]
Upon closer inspection, the sparc code in s_lock.c is dead code, and
always has been, because it's not got any .globl declaration! We've
been relying on the solaris_sparc.s code instead. Rip it out.
(Not back-patched, since this is just cosmetic cleanup.)
Fix typo in comment.
Tom Lane [2006年5月11日 21:58:22 +0000 (21:58 +0000)]
Remove unnecessary .seg/.section directives, per Alan Stange.
Use SQL standard '' rather than \' for tutorial/sample code.
Backpatch to 8.1.X.
Tom Lane [2006年5月11日 19:15:36 +0000 (19:15 +0000)]
Code review for standard_conforming_strings patch. Fix it so it does not
throw warnings for 100%-SQL-standard constructs, clean up some minor
infelicities, try to un-break ecpg to the best of my ability. (It's not clear
how ecpg is going to find out the setting of standard_conforming_strings,
though.) I think pg_dump still needs work, too.
Tom Lane [2006年5月10日 23:18:39 +0000 (23:18 +0000)]
Clean up code associated with updating pg_class statistics columns
(relpages/reltuples). To do this, create formal support in heapam.c for
"overwrite" tuple updates (including xlog replay capability) and use that
instead of the ad-hoc overwrites we'd been using in VACUUM and CREATE INDEX.
Take the responsibility for updating stats during CREATE INDEX out of the
individual index AMs, and do it where it belongs, in catalog/index.c. Aside
from being more modular, this avoids having to update the same tuple twice in
some paths through CREATE INDEX. It's probably not measurably faster, but
for sure it's a lot cleaner than before.
Some optimizations by Volkan YAZICI <yazicivo@ttnet.net.tr>
Reduce size of critical section and remove call of user-defined functions in
insertion and deletion, modify gistSplit() to do not use buffers.
TODO: gistvacuumcleanup and XLOG
Revert documentation mention of array dimension checking, in next paragraph.
Mention array dimmensions are not enforced either.
Build server libpgport with all non-FRONTEND object files. This is to
fix a Win32 bug where pipe.c included a file that used FRONTEND, but it
wasn't on the server-build list.
Tom Lane [Mon, 8 May 2006 00:00:17 +0000 (00:00 +0000)]
Rewrite btree vacuuming to fold the former bulkdelete and cleanup operations
into a single mostly-physical-order scan of the index. This requires some
ticklish interlocking considerations, but should create no material
performance impact on normal index operations (at least given the
already-committed changes to make scans work a page at a time). VACUUM
itself should get significantly faster in any index that's degenerated to a
very nonlinear page order. Also, we save one pass over the index entirely,
except in the case where there were no deletions to do and so only one pass
happened anyway.
Original patch by Heikki Linnakangas, rework by Tom Lane.
Tom Lane [Sun, 7 May 2006 01:21:30 +0000 (01:21 +0000)]
Rewrite btree index scans to work a page at a time in all cases (both
btgettuple and btgetmulti). This eliminates the problem of "re-finding" the
exact stopping point, since the stopping point is effectively always a page
boundary, and index items are never moved across pre-existing page boundaries.
A small penalty is that the keys_are_unique optimization is effectively
disabled (and, therefore, is removed in this patch), causing us to apply
_bt_checkkeys() to at least one more tuple than necessary when looking up a
unique key. However, the advantages for non-unique cases seem great enough to
accept this tradeoff. Aside from simplifying and (sometimes) speeding up the
indexscan code, this will allow us to reimplement btbulkdelete as a largely
sequential scan instead of index-order traversal, thereby significantly
reducing the cost of VACUUM. Those changes will come in a separate patch.
Original patch by Heikki Linnakangas, rework by Tom Lane.
Use $(LIBS:-lpgport=) rather than $(patsubst -lpgport,, $(LIBS)), for consistency.
Add description:
* %Disallow changing DEFAULT expression of a SERIAL column?
>
> This should be done only if the existing SERIAL problems cannot be
> fixed.
>
Recommend more clearly custom pg_dump format over tar, buy showing
custom format examples first.
Document SSL CRL usage by libpq.
Tom Lane [Sat, 6 May 2006 15:51:07 +0000 (15:51 +0000)]
Further minor simplification of relcache startup: don't need a static
needNewCacheFile flag anymore, it can just be local in RelationCacheInitializePhase2.
Add SSL CRL support to libpq. Recently added to the backend.
Issue a log message if a CRL file exists and the SSL library does not
support CRL certificates.
Seems some NetBSD 3.0 x86 systems still need float8-small-is-zero, so
patch reverted.
On Solaris ASM, / '/' is the comment for x86, while '!' is the comment
for Sparc
Robert Lor
Use regression results float8-small-is-zero only for NetBSD < 3.0.
Backpatch to 8.1.X.
Simon Burge
Change Solaris comments from / to !.
Robert Lor
Update standards URL.
Robert Treat
Add/ cleanup:
< * %Disallow changing default expression of a SERIAL column?
> * %Disallow changing DEFAULT expression of a SERIAL column?
472a473,476
> * Add DEFAULT .. AS OWNER so permission checks are done as the table
> owner
>
> This would be useful for SERIAL nextval() calls and CHECK constraints.
Tom Lane [Thu, 4 May 2006 22:18:38 +0000 (22:18 +0000)]
Don't try to compile SSL CRL support if local SSL installation hasn't
got it. Per buildfarm failure on 'canary'.
Tom Lane [Thu, 4 May 2006 20:39:34 +0000 (20:39 +0000)]
Code review for contrib/pg_freespacemap. Add a storedpages column to
pg_freespacemap_relations --- while one could theoretically get that
number by counting rows in pg_freespacemap_pages, it's surely the hard
way to do it. Avoid expensive and inconvenient conversion to and from
text format. Minor code and docs cleanup.
Tom Lane [Thu, 4 May 2006 18:51:36 +0000 (18:51 +0000)]
Simplify relcache startup sequence. With the new design of InitPostgres
it's not necessary to have three separate calls anymore. This patch also
fixes things so we don't try to read pg_internal.init until after we've
obtained lock on the target database; which was fairly harmless, but it's
certainly cleaner this way.
Tom Lane [Thu, 4 May 2006 16:07:29 +0000 (16:07 +0000)]
Rethink the locking mechanisms used for CREATE/DROP/RENAME DATABASE.
The former approach used ExclusiveLock on pg_database, which being a
cluster-wide lock meant only one of these operations could proceed at
a time; worse, it also blocked all incoming connections in ReverifyMyDatabase.
Now that we have LockSharedObject(), we can use locks of different types
applied to databases considered as objects. This allows much more
flexible management of the interlocking: two CREATE DATABASEs need not
block each other, and need not block connections except to the template
database being used. Similarly DROP DATABASE doesn't block unrelated
operations. The locking used in flatfiles.c is also much narrower in
scope than before. Per recent proposal.
Tom Lane [Wed, 3 May 2006 22:45:26 +0000 (22:45 +0000)]
Create a syscache for pg_database-indexed-by-oid, and make use of it
in various places that were previously doing ad hoc pg_database searches.
This may speed up database-related privilege checks a little bit, but
the main motivation is to eliminate the performance reason for having
ReverifyMyDatabase do such a lot of stuff (viz, avoiding repeat scans
of pg_database during backend startup). The locking reason for having
that routine is about to go away, and it'd be good to have the option
to break it up.
Make GIN opclass worked with intarray extensions
Fix typo noticed by Alvaro Herrera
Tom Lane [Wed, 3 May 2006 00:24:56 +0000 (00:24 +0000)]
Fix calculation of plan node extParams to account for the possibility that one
initPlan sets a parameter for another. This could not (I think) happen before
8.1, but it's possible now because the initPlans generated by MIN/MAX
optimization might themselves use initPlans. We attach those initPlans as
siblings of the MIN/MAX ones, not children, to avoid duplicate computation
when multiple MIN/MAX aggregates are present; so this leads to the case of an
initPlan needing the result of a sibling initPlan, which is not possible with
ordinary query nesting. Hadn't been noticed because in most contexts having
too much stuff listed in extParam is fairly harmless. Fixes "plan should not
reference subplan's variable" bug reported by Catalin Pitis.
Tom Lane [Tue, 2 May 2006 22:25:10 +0000 (22:25 +0000)]
Clean up API for ambulkdelete/amvacuumcleanup as per today's discussion.
This formulation requires every AM to provide amvacuumcleanup, unlike before,
but it's surely a whole lot cleaner. Also, add an 'amstorage' column to
pg_am so that we can get rid of hardwired knowledge in DefineOpClass().
Tom Lane [Tue, 2 May 2006 18:07:51 +0000 (18:07 +0000)]
Fix broken markup.
Tom Lane [Tue, 2 May 2006 15:48:11 +0000 (15:48 +0000)]
Suppress some gcc warnings.
Tom Lane [Tue, 2 May 2006 15:45:37 +0000 (15:45 +0000)]
Fix grammar of new error message.
Add GIN opclases for another types
GIN: Generalized Inverted iNdex.
text[], int4[], Tsearch2 support for GIN.
Tom Lane [Tue, 2 May 2006 04:34:18 +0000 (04:34 +0000)]
Avoid assuming that statistics for a parent relation reflect the properties of
the union of its child relations as well. This might have been a good idea
when it was originally coded, but it's a fatally bad idea when inheritance is
being used for partitioning. It's better to have no stats at all than
completely misleading stats. Per report from Mark Liberman.
The bug arguably exists all the way back, but I've only patched HEAD and 8.1
because we weren't particularly trying to support partitioning before 8.1.
Eventually we ought to look at deriving union statistics instead of just
punting, but for now the drop kick looks good.
Tom Lane [Mon, 1 May 2006 23:22:43 +0000 (23:22 +0000)]
Provide a namespace.c function for lookup of an operator with exact
input datatypes given, and use this before trying OpernameGetCandidates.
This is faster than the old method when there's an exact match, and it
does not seem materially slower when there's not. And it definitely
makes some of the callers cleaner, because they didn't really want to
know about a list of candidates anyway. Per discussion with Atsushi Ogawa.
Tom Lane [2006年4月30日 21:15:33 +0000 (21:15 +0000)]
Code review for GRANT CONNECT patch. Spell the privilege as CONNECT not
CONNECTION, fix a number of places that were missed (eg pg_dump support),
avoid executing an extra search of pg_database during startup.
Tom Lane [2006年4月30日 18:30:40 +0000 (18:30 +0000)]
Improve the representation of FOR UPDATE/FOR SHARE so that we can
support both FOR UPDATE and FOR SHARE in one command, as well as both
NOWAIT and normal WAIT behavior. The more general code is actually
simpler and cleaner.
Done:
> o -Allow per-database permissions to be set via GRANT
Add GRANT CONNECTION ON DATABASE, to be used in addition to pg_hba.conf.
Gevik Babakhani
Add question mark:
> * %Disallow changing default expression of a SERIAL column?
Revert patch pending more discussion:
Disallow changing DEFAULT expression of a SERIAL column.
Tom Lane [2006年4月29日 20:52:56 +0000 (20:52 +0000)]
Remove sema.c, superseded by win32_sema.c.
Tom Lane [2006年4月29日 20:47:31 +0000 (20:47 +0000)]
Rearrange some configure.in comments for better readability.
Commit configure and pg_config.h.in, missed in last configure.in
update.
Tom Lane [2006年4月29日 20:13:07 +0000 (20:13 +0000)]
We only need to add thread.c on non-WIN32 platforms, since get_home_path
doesn't use pqGetpwuid on WIN32. Rather than try to figure out why it
won't build on WIN32, just remove it.
Done:
> * -Disallow changing default expression of a SERIAL column
Disallow changing DEFAULT expression of a SERIAL column.
Dhanaraj M
Add Win32 semaphore implementation, rather than mimicking SysV
semaphores.
Qingqing Zhou
Solaris tas() uses 'int' now.
Theo Schlossnagle
Intel compiler has a bug/misoptimization in checking for division by NAN
(NaN == 0), -mp1 fixes it, so add it to the CFLAGS. Autoconf run.
Jeremy Drake
Fix s_lock_test to use tas.o file, if needed.
Tom Lane [2006年4月28日 20:57:49 +0000 (20:57 +0000)]
Remove the restriction originally coded into optimize_minmax_aggregates() that
MIN/MAX not be converted to use an index if the query WHERE clause contains
any volatile functions or subplans.
I had originally feared that the conversion might alter the behavior of such a
query with respect to a volatile function. Well, so it might, but only in the
sense that the function would get evaluated at a subset of the table rows
rather than all of them --- and we have never made any such guarantee anyway.
(For instance, we don't refuse to use an index for an ordinary non-aggregate
query when one of the non-indexable filter conditions contains a volatile
function.)
The prohibition against subplans was because of worry that that case wasn't
adequately tested, which it wasn't, but it turns out to be possible to make
8.1 fail anyway:
regression=# select o.ten, (select max(unique2) from tenk1 i where ten = o.ten
or ten = (select f1 from int4_tbl limit 1)) from tenk1 o;
ERROR: direct correlated subquery unsupported as initplan
This is due to bogus code in SS_make_initplan_from_plan (it's an initplan,
ergo it can't have any parParams). Having fixed that, we might as well allow
subplans as well as initplans.
Modify Solaris compiler build rules to use the cpp preprocessor, the the
x86 file.
Darin -> Darwin.
Remove extra 'else' in solaris compiler code.
Remove "volatile" from tas function, per TOm.
Update list of platforms that have a list of exported symbols.
Tom Lane [2006年4月28日 02:53:20 +0000 (02:53 +0000)]
Arrange to strip libpq.so of symbols that aren't officially supposed to
be exported on Linux and Darwin. We already did this on Windows but
that's not enough, as evidenced by the fact that libecpg had an unexpected
dependency on one such symbol. We should try to do it on more platforms.
Fix ecpg's oversight, and bump libpq's major .so version number to reflect
the unwanted but nonetheless real ABI break.
This is the main PostgreSQL git repository.
RSS
Atom