git.postgresql.org Git - postgresql.git/log
Tom Lane [2008年3月24日 18:08:47 +0000 (18:08 +0000)]
Add a new ereport auxiliary function errdetail_log(), which works the same as
errdetail except the string goes only to the server log, replacing the normal
errdetail there. This provides a reasonably clean way of dealing with error
details that are too security-sensitive or too bulky to send to the client.
This commit just adds the infrastructure --- actual uses to follow.
Add URL for:
* SMP scalability improvements
> http://archives.postgresql.org/pgsql-hackers/2007-09/msg00206.php
Add URL to:
* SMP scalability improvements
> http://archives.postgresql.org/pgsql-hackers/2008-03/msg00361.php
Add to TODO:
>
> * SMP scalability improvements
>
> http://archives.postgresql.org/pgsql-hackers/2007-07/msg00439.php
Add URL:
* Allow statistics last vacuum/analyze execution times to be displayed
without requiring stats_row_level to be enabled
>
> http://archives.postgresql.org/pgsql-docs/2007-04/msg00028.php
>
Add to TODO:
> * Improve reporting of UNION type mismatches
>
> http://archives.postgresql.org/pgsql-hackers/2007-04/msg00944.php
> http://archives.postgresql.org/pgsql-hackers/2008-03/msg00597.php
Update wording:
< o Allow pre/data/post files when dumping a single object, for
< performance reasons
> o Allow pre/data/post files when schema and data are dumped
> separately, for performance reasons
Update text:
< o Support pgxs
> o Support pgxs when using MSVC
Add:
> http://archives.postgresql.org/pgsql-patches/2008-02/msg00176.php
Re-add:
>
> * Avoid tuple some tuple copying in sort routines
>
> http://archives.postgresql.org/pgsql-hackers/2008-02/msg01206.php
Add:
>
> * Sort large UPDATE/DELETEs so it is done in heap order
>
> http://archives.postgresql.org/pgsql-hackers/2008-01/msg01119.php
Add URL for:
* Do async I/O for faster random read-ahead of data
Async I/O allows multiple I/O requests to be sent to the disk with
results coming back asynchronously.
> http://archives.postgresql.org/pgsql-patches/2008-01/msg00170.php
Done:
<
< * Avoid tuple some tuple copying in sort routines
<
< http://archives.postgresql.org/pgsql-hackers/2008-02/msg01206.php
Tom Lane [2008年3月23日 00:54:04 +0000 (00:54 +0000)]
Avoid a useless tuple copy within nodeMaterial. Neil Conway
Add to pg_dump TODO:
> o Allow pre/data/post files when dumping a single object, for
> performance reasons
>
> http://archives.postgresql.org/pgsql-hackers/2008-02/msg00205.php
>
Tom Lane [2008年3月23日 00:24:20 +0000 (00:24 +0000)]
Create a function quote_nullable(), which works the same as quote_literal()
except that it returns the string 'NULL', rather than a SQL null, when called
with a null argument. This is often a much more useful behavior for
constructing dynamic queries. Add more discussion to the documentation
about how to use these functions.
Brendan Jurd
Add to Win3 TODO:
>
> o Fix MSVC NLS support, like for to_char()
>
> http://archives.postgresql.org/pgsql-hackers/2008-02/msg00485.php
> http://archives.postgresql.org/pgsql-patches/2008-02/msg00038.php
Add to TODO:
>
> * Improve WAL concurrency by increasing lock granularity
>
> http://archives.postgresql.org/pgsql-hackers/2008-02/msg00556.php
>
Add to Win32 TODO
>
> o Support pgxs
Add to TODO:
>
> * Avoid tuple some tuple copying in sort routines
>
> http://archives.postgresql.org/pgsql-hackers/2008-02/msg01206.php
Add URL for TODO:
o Add checks to prevent a CREATE RULE views on inherited tables
> http://archives.postgresql.org/pgsql-general/2008-03/msg00077.php
Tom Lane [2008年3月22日 22:32:19 +0000 (22:32 +0000)]
Refactor to_char/to_date formatting code; primarily, replace DCH_processor
with two new functions DCH_to_char and DCH_from_char that have less confusing
APIs. Brendan Jurd
Add to TODO:
>
> o Add checks to prevent a CREATE RULE views on inherited tables
>
> http://archives.postgresql.org/pgsql-general/2008-02/msg01420.php
Add server side lo_import(filename, oid) function.
Add URL for:
* Simplify ability to create partitioned tables
> http://archives.postgresql.org/pgsql-hackers/2008-01/msg00387.php
Add URL for:
* Simplify ability to create partitioned tables
> http://archives.postgresql.org/pgsql-hackers/2008-01/msg00248.php
Add TODO:
>
> * Improve performance of shared invalidation queue for multiple CPUs
>
> http://archives.postgresql.org/pgsql-performance/2008-01/msg00023.php
Add URLs for:
* Simplify ability to create partitioned tables
This would allow creation of partitioned tables without requiring
creation of triggers or rules for INSERT/UPDATE/DELETE, and constraints
for rapid partition selection. Options could include range and hash
partition selection.
> http://archives.postgresql.org/pgsql-hackers/2008-01/msg00028.php
> http://archives.postgresql.org/pgsql-hackers/2008-01/msg00413.php
Tom Lane [2008年3月21日 22:41:48 +0000 (22:41 +0000)]
Remove TypeName struct's timezone flag, which has been write-only storage
for a very long time --- in current usage it's entirely redundant with the
name field.
Tom Lane [2008年3月21日 22:10:56 +0000 (22:10 +0000)]
Give an explicit error for serial[], rather than silently ignoring
the array decoration as the code had been doing.
Tom Lane [2008年3月21日 21:08:31 +0000 (21:08 +0000)]
Report the current queries of all backends involved in a deadlock
(if they'd be visible to the current user in pg_stat_activity).
This might look like it's subject to race conditions, but it's actually
pretty safe because at the time DeadLockReport() is constructing the
report, we haven't yet aborted our transaction and so we can expect that
everyone else involved in the deadlock is still blocked on some lock.
(There are corner cases where that might not be true, such as a statement
timeout triggering in another backend before we finish reporting; but at
worst we'd report a misleading activity string, so it seems acceptable
considering the usefulness of reporting the queries.)
Original patch by Itagaki Takahiro, heavily modified by me.
Add:
>
> * Convert single quotes to apostrophes in the PDF documentation
>
> http://archives.postgresql.org/pgsql-docs/2007-12/msg00059.php
>
Add:
>
> * Fix inconsistent precedence of =, >, and < compared to <>, >=, and <=
>
> http://archives.postgresql.org/pgsql-bugs/2007-12/msg00145.php
Add:
>
> o Prevent SSL from sending network packets to avoid interference
> with Win32 signal emulation
>
> http://archives.postgresql.org/pgsql-hackers/2007-12/msg00455.php
Corrected version number.
Document that soft-mounting NFS is not recommended.
More README src cleanups.
Tom Lane [2008年3月21日 03:23:30 +0000 (03:23 +0000)]
Adjust pgstatindex() to give correct answers for indexes larger than
2^31 blocks. Also fix pg_relpages() for the same case.
Tatsuhito Kasahara
Generate dummy probes.h for MSVC builds.
Tom Lane [2008年3月21日 01:31:43 +0000 (01:31 +0000)]
Get rid of a bunch of #ifdef HAVE_INT64_TIMESTAMP conditionals by inventing
a new typedef TimeOffset to represent an intermediate time value. It's
either int64 or double as appropriate, and in most usages will be measured
in microseconds or seconds the same as Timestamp. We don't call it
Timestamp, though, since the value doesn't necessarily represent an absolute
time instant.
Warren Turkal
Tom Lane [2008年3月20日 21:42:48 +0000 (21:42 +0000)]
Arrange for an explicit cast applied to an ARRAY[] constructor to be applied
directly to all the member expressions, instead of the previous implementation
where the ARRAY[] constructor would infer a common element type and then we'd
coerce the finished array after the fact. This has a number of benefits,
one being that we can allow an empty ARRAY[] construct so long as its
element type is specified by such a cast.
Brendan Jurd, minor fixes by me.
Add a couple of missing FreeQueryDesc calls. Noticed while testing a
framework to keep track of snapshots in use.
Make source code READMEs more consistent. Add CVS tags to all README files.
Tom Lane [2008年3月20日 17:42:51 +0000 (17:42 +0000)]
Dept of second thoughts: --no-tablespaces had better also prevent
pg_dumpall from attaching TABLESPACE options to CREATE DATABASE commands.
Tom Lane [2008年3月20日 17:36:58 +0000 (17:36 +0000)]
Support a --no-tablespaces option in pg_dump/pg_dumpall/pg_restore, so that
dumps can be loaded into databases without the same tablespaces that the
source had. The option acts by suppressing all "SET default_tablespace"
commands, and also CREATE TABLESPACE commands in pg_dumpall's case.
Gavin Roy, with documentation and minor fixes by me.
Added ECPGget_PGconn() function to ecpglib, courtesy of Mike Aubury.
Removed one include file from connect-test1.
Changed statement escaping to not escape continuation line markers.
Add the missing cyrillic "Yo" characters ('e' and 'E' with two dots) to the
ISO_8859-5 <-> MULE_INTERNAL conversion tables.
This was discovered when trying to convert a string containing those characters
from ISO_8859-5 to Windows-1251, because we use MULE_INTERNAL/KOI8R as an
intermediate encoding between those two.
While the missing "Yo" was just an omission in the conversion tables, there are
a few other characters like the "Numero" sign ("No" as a single character) that
exists in all the other cyrillic encodings (win1251, ISO_8859-5 and cp866), but
not in KOI8R. Added comments about that.
Patch by Sergey Burladyan. Back-patch to 7.4.
Remove another useless snapshot creation.
Tom Lane [2008年3月19日 18:38:30 +0000 (18:38 +0000)]
Support ALTER TYPE RENAME. Petr Jelinek
We no longer need a snapshot set after opening the finishing transaction: this
is redundant because autovacuum now always analyzes a single table per
transaction.
Add -M (query mode) option per ITAGAKI Takahiro
Tom Lane [2008年3月19日 02:40:37 +0000 (02:40 +0000)]
Fix regexp substring matching (substring(string from pattern)) for the corner
case where there is a match to the pattern overall but the user has specified
a parenthesized subexpression and that subexpression hasn't got a match.
An example is substring('foo' from 'foo(bar)?'). This should return NULL,
since (bar) isn't matched, but it was mistakenly returning the whole-pattern
match instead (ie, 'foo'). Per bug #4044 from Rui Martins.
This has been broken since the beginning; patch in all supported versions.
The old behavior was sufficiently inconsistent that it's impossible to believe
anyone is depending on it.
Add libpq new API lo_import_with_oid() which is similar to lo_import()
except that lob's oid can be specified.
Fix tps calculation when -C supplied. Per Yoshiyuki Asaba.
Change Copyright owner from mine to PostgreSQL Global Development Group
Fix minor message typo
Spit items:
* Experiment with multi-threaded backend better I/O utilization
This would allow a single query to make use of multiple I/O channels
simultaneously. One idea is to create a background reader that can
pre-fetch sequential and index scan pages needed by other backends.
This could be expanded to allow concurrent reads from multiple devices
in a partitioned table.
* Experiment with multi-threaded backend better CPU utilization
This would allow several CPUs to be used for a single query, such as
for sorting or query execution.
Update TODO description:
* Speed WAL recovery by allowing more than one page to be prefetched
This should be done utilizing the same infrastructure used for
prefetching in general to avoid introducing complex error-prone code
in WAL replay.
Add find_typedef comments for Linux.
Add find_typedef comment.
Add Linux support to find_typedefs, with help from Alvaro.
Tom Lane [2008年3月18日 22:04:14 +0000 (22:04 +0000)]
Arrange to "inline" SQL functions that appear in a query's FROM clause,
are declared to return set, and consist of just a single SELECT. We
can replace the FROM-item with a sub-SELECT and then optimize much as
if we were dealing with a view. Patch from Richard Rowell, cleaned up
by me.
Add to TODO:
>
> * Consider not storing a NULL bitmap on disk if all the NULLs are
> trailing
>
> http://archives.postgresql.org/pgsql-hackers/2007-12/msg00624.php
> http://archives.postgresql.org/pgsql-patches/2007-12/msg00109.php
>
Don't need -Wno-error anymore, because flex is no longer producing warnings.
Catch all errors in for and while loops in makefiles. Don't ignore any
errors in any commands, including in various clean targets that have so far
been handled inconsistently. make -i is available to ignore all errors in
a consistent and official way.
cvsweb lives on anoncvs.postgresql.org these days.
Wiki page about cvs now lives in the main wiki, the one
on developer.postgresql.org is going away.
Add TODO URLs for:
o Allow UPDATE tab SET ROW (col, ...) = (SELECT...)
> http://archives.postgresql.org/pgsql-patches/2007-04/msg00315.php
> http://archives.postgresql.org/pgsql-patches/2008-03/msg00237.php
Move elog(DEBUG4) call outside the locked area, per suggestion from Tom Lane.
Add URLs for :
* Speed WAL recovery by allowing more than one page to be prefetched
This involves having a separate process that can be told which pages
the recovery process will need in the near future.
> http://archives.postgresql.org/pgsql-general/2007-12/msg00683.php
> http://archives.postgresql.org/pgsql-hackers/2007-12/msg00497.php
<
Tom Lane [2008年3月18日 03:54:52 +0000 (03:54 +0000)]
Advance multiple array keys rightmost-first instead of leftmost-first
during a bitmap index scan. This cannot affect the query results
(since we're just dumping the TIDs into a bitmap) but it might offer
some advantage in locality of access to the index. Per Greg Stark.
Add TODO:
> o Recreate pg_xlog/archive_status/ if it doesn't exist after
> restoring from a PITR backup
>
> http://archives.postgresql.org/pgsql-hackers/2007-12/msg00487.php
Tom Lane [2008年3月18日 01:49:44 +0000 (01:49 +0000)]
Fix our printf implementation to follow spec: if a star parameter
value for a precision is negative, act as though precision weren't
specified at all, that is the whole .* part of the format spec should
be ignored. Our previous coding took it as .0 which is certainly
wrong. Per report from Kris Jurka and local testing.
Possibly this should be back-patched, but it would be good to get
some more testing first; in any case there are no known cases where
there's really a problem on the backend side.
Add to TODO:
>
> * Consider Cartesian joins when both relations are needed to form an
> indexscan qualification for a third relation
>
> http://archives.postgresql.org/pgsql-performance/2007-12/msg00090.php
Add URL for:
o Allow COPY to report error lines and continue
This requires the use of a savepoint before each COPY line is
processed, with ROLLBACK on COPY failure.
> http://archives.postgresql.org/pgsql-hackers/2007-12/msg00572.php
Add to TODO:
>
> * Allow SSL key file permission checks to be optionally disabled when
> sharing SSL keys with other applications
>
> http://archives.postgresql.org/pgsql-bugs/2007-12/msg00069.php
Add:
>
> * Reduce BIT data type overhead using short varlena headers
>
> http://archives.postgresql.org/pgsql-general/2007-12/msg00273.php
Add to TODO:
> * Reduce file system activity overhead of statistics file pgstat.stat
>
> http://archives.postgresql.org/pgsql-general/2007-12/msg00106.php
>
Add to TODO:
> * Consider if CommandCounterIncrement() can avoid its
> AcceptInvalidationMessages() call
>
> http://archives.postgresql.org/pgsql-committers/2007-11/msg00585.php
Add URL for:
* Add SQL:2003 WITH RECURSIVE (hierarchical) queries to SELECT
> http://archives.postgresql.org/pgsql-hackers/2007-11/msg01334.php
Add:
>
> o Remove pre-7.3 pg_dump code that assumes pg_depend does not exit
Add URL for:
* Improve text search error messages
> http://archives.postgresql.org/pgsql-hackers/2007-11/msg01146.php
Added to TODO:
> * Improve text search error messages
>
> http://archives.postgresql.org/pgsql-hackers/2007-10/msg00966.php
>
>
> * Fix /contrib/ltree operator
>
> http://archives.postgresql.org/pgsql-bugs/2007-11/msg00044.php
Add TODO:
>
> o Fix server restart problem when the server was shutdown during
> a PITR backup
>
> http://archives.postgresql.org/pgsql-hackers/2007-11/msg00800.php
>
Adjust TODO spacing.
Add TODO URL for:
* Consider increasing the number of default statistics target, and
reduce statistics target overhead
> http://archives.postgresql.org/pgsql-hackers/2008-01/msg01066.php
Enable probes to work with Mac OS X Leopard and other OSes that will
support DTrace in the future.
Switch from using DTRACE_PROBEn macros to the dynamically generated macros.
Use "dtrace -h" to create a header file that contains the dynamically
generated macros to be used in the source code instead of the DTRACE_PROBEn
macros. A dummy header file is generated for builds without DTrace support.
Author: Robert Lor <Robert.Lor@sun.com>
We need to rebuild objfiles.txt when one of the subdirectories' objfiles.txt
changed in case a new file got added.
Add:
>
> o Allow Kerberos to disable stripping of realms so we can
> check the username@realm against multiple realms
>
> http://archives.postgresql.org/pgsql-hackers/2007-11/msg00009.php
Fix postgres --describe-config for guc enums, breakage noted by Alvaro.
While at it, rename option lookup functions to make names clearer, per
discussion with Tom.
Tom Lane [2008年3月17日 17:13:54 +0000 (17:13 +0000)]
Revert thinko introduced into prefix_selectivity() by my recent patch:
make_greater_string needs the < procedure not the >= one. Spotted by
Peter.
Move ProcState definition into sinvaladt.c from sinvaladt.h, since it's not
needed anywhere after my previous patch. Noticed by Tom Lane.
Also, remove #include <signal.h> from sinval.c.
Tom Lane [2008年3月17日 03:45:36 +0000 (03:45 +0000)]
Grab some low-hanging fruit in the new hash index build code.
oprofile shows that a nontrivial amount of time is being spent in
repeated calls to index_getprocinfo, which really only needs to be
called once. So do that, and inline _hash_datum2hashkey to make it
work.
Tom Lane [2008年3月17日 02:18:55 +0000 (02:18 +0000)]
Fix TransactionIdIsCurrentTransactionId() to use binary search instead of
linear search when checking child-transaction XIDs. This makes for an
important speedup in transactions that have large numbers of children,
as in a recent example from Craig Ringer. We can also get rid of an
ugly kluge that represented lists of TransactionIds as lists of OIDs.
Heikki Linnakangas
Done:
> o -During index creation, pre-sort the tuples to improve build speed
Tom Lane [2008年3月16日 23:57:51 +0000 (23:57 +0000)]
Add a note to the CREATE INDEX reference page about the impact of
maintenance_work_mem and effective_cache_size on index creation speed.
Tom Lane [2008年3月16日 23:15:08 +0000 (23:15 +0000)]
When creating a large hash index, pre-sort the index entries by estimated
bucket number, so as to ensure locality of access to the index during the
insertion step. Without this, building an index significantly larger than
available RAM takes a very long time because of thrashing. On the other
hand, sorting is just useless overhead when the index does fit in RAM.
We choose to sort when the initial index size exceeds effective_cache_size.
This is a revised version of work by Tom Raney and Shreya Bhargava.
Modify interactions between sinval.c and sinvaladt.c. The code that actually
deals with the queue, including locking etc, is all in sinvaladt.c. This means
that the struct definition of the queue, and the queue pointer, are now
internal "implementation details" inside sinvaladt.c.
Per my proposal dated 25-Jun-2007 and followup discussion.
Some cleanups of enum-guc code, per comments from Tom.
Tom Lane [2008年3月15日 20:46:31 +0000 (20:46 +0000)]
Change hash index creation so that rather than always establishing exactly
two buckets at the start, we create a number of buckets appropriate for the
estimated size of the table. This avoids a lot of expensive bucket-split
actions during initial index build on an already-populated table.
This is one of the two core ideas of Tom Raney and Shreya Bhargava's patch
to reduce hash index build time. I'm committing it separately to make it
easier for people to test the effects of this separately from the effects
of their other core idea (pre-sorting the index entries by bucket number).
Tom Lane [2008年3月14日 23:49:28 +0000 (23:49 +0000)]
Fix inappropriately-timed memory context switch in autovacuum_do_vac_analyze.
This accidentally failed to fail before 8.3, because the context we were
switching back to was long-lived anyway; but it sure looks risky as can be
now. Well spotted by Pavan Deolasee.
This is the main PostgreSQL git repository.
RSS
Atom