From: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2006年3月28日 21:17:23 +0000 (+0000)
Subject: Repair longstanding error in btree xlog replay: XLogReadBuffer should be
X-Git-Tag: REL8_2_BETA1~1217
X-Git-Url: http://git.postgresql.org/gitweb/?a=commitdiff_plain;h=288551fc60fc61ffeda63a93af00b10b73d8957d;p=postgresql.git
Repair longstanding error in btree xlog replay: XLogReadBuffer should be
passed extend = true whenever we are reading a page we intend to reinitialize
completely, even if we think the page "should exist". This is because it
might indeed not exist, if the relation got truncated sometime after the
current xlog record was made and before the crash we're trying to recover
from. These two thinkos appear to explain both of the old bug reports
discussed here:
http://archives.postgresql.org/pgsql-hackers/2005-05/msg01369.php
---
diff --git a/src/backend/access/nbtree/nbtxlog.c b/src/backend/access/nbtree/nbtxlog.c
index 2b5c8f73776..a13a7366b0c 100644
--- a/src/backend/access/nbtree/nbtxlog.c
+++ b/src/backend/access/nbtree/nbtxlog.c
@@ -8,7 +8,7 @@
 * Portions Copyright (c) 1994, Regents of the University of California
 *
 * IDENTIFICATION
- *	 $PostgreSQL: pgsql/src/backend/access/nbtree/nbtxlog.c,v 1.27 2006年03月24日 04:32:12 tgl Exp $
+ *	 $PostgreSQL: pgsql/src/backend/access/nbtree/nbtxlog.c,v 1.28 2006年03月28日 21:17:23 tgl Exp $
 *
 *-------------------------------------------------------------------------
 */
@@ -243,7 +243,7 @@ btree_xlog_split(bool onleft, bool isroot,
 	rightsib = (onleft) ? xlrec->otherblk : targetblk;
 
 	/* Left (original) sibling */
-	buffer = XLogReadBuffer(false, reln, leftsib);
+	buffer = XLogReadBuffer(true, reln, leftsib);
 	if (!BufferIsValid(buffer))
 		elog(PANIC, "btree_split_redo: lost left sibling");
 
@@ -504,7 +504,7 @@ btree_xlog_delete_page(bool ismeta,
 	}
 
 	/* Rewrite target page as empty deleted page */
-	buffer = XLogReadBuffer(false, reln, target);
+	buffer = XLogReadBuffer(true, reln, target);
 	if (!BufferIsValid(buffer))
 		elog(PANIC, "btree_delete_page_redo: lost target page");
 	page = (Page) BufferGetPage(buffer);
</div><div class="naked_ctrl">
<form action="/index.cgi/contrast" method="get" name="gate">
<p><a href="http://altstyle.alfasado.net">AltStyle</a> によって変換されたページ <a href="https://git.postgresql.org/gitweb/?a=commitdiff_plain&amp;h=288551fc60fc61ffeda63a93af00b10b73d8957d&amp;p=postgresql.git">(-&gt;オリジナル)</a>
/ <label>アドレス: <input type="text" name="naked_post_url" value="https://git.postgresql.org/gitweb/?a=commitdiff_plain&amp;h=288551fc60fc61ffeda63a93af00b10b73d8957d&amp;p=postgresql.git" size="22" /></label> <label>モード: <select name="naked_post_mode">
<option value="default">デフォルト</option>
<option value="speech">音声ブラウザ</option>
<option value="ruby">ルビ付き</option>
<option value="contrast" selected="selected">配色反転</option>
<option value="larger-text">文字拡大</option>
<option value="mobile">モバイル</option>
</select>
<input type="submit" value="表示" />
</p>
</form>
</div>