git.postgresql.org Git - postgresql.git/commitdiff

git projects / postgresql.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: fba60e5)
Don't connect() to a wildcard address in test_postmaster_connection().
Sun, 8 Nov 2015 22:28:53 +0000 (17:28 -0500)
Sun, 8 Nov 2015 22:28:53 +0000 (17:28 -0500)
At least OpenBSD, NetBSD, and Windows don't support it. This repairs
pg_ctl for listen_addresses='0.0.0.0' and listen_addresses='::'. Since
pg_ctl prefers to test a Unix-domain socket, Windows users are most
likely to need this change. Back-patch to 9.1 (all supported versions).
This could change pg_ctl interaction with loopback-interface firewall
rules. Therefore, in 9.4 and earlier (released branches), activate the
change only on known-affected platforms.

Reported (bug #13611) and designed by Kondo Yuta.


diff --git a/src/bin/pg_ctl/pg_ctl.c b/src/bin/pg_ctl/pg_ctl.c
index dacdfef323c07b5d5c984f021e4f3318be1383ce..03b9770d5007ebc9e93b0936e10534dcdc80dd7e 100644 (file)
--- a/src/bin/pg_ctl/pg_ctl.c
+++ b/src/bin/pg_ctl/pg_ctl.c
@@ -646,9 +646,20 @@ test_postmaster_connection(pgpid_t pm_pid, bool do_checkpoint)
return PQPING_NO_ATTEMPT;
}
- /* If postmaster is listening on "*", use localhost */
+ /*
+ * Map listen-only addresses to counterparts usable
+ * for establishing a connection. connect() to "::"
+ * or "0.0.0.0" is not portable to OpenBSD 5.0 or to
+ * Windows Server 2008, and connect() to "::" is
+ * additionally not portable to NetBSD 6.0. (Cygwin
+ * does handle both addresses, though.)
+ */
if (strcmp(host_str, "*") == 0)
strcpy(host_str, "localhost");
+ else if (strcmp(host_str, "0.0.0.0") == 0)
+ strcpy(host_str, "127.0.0.1");
+ else if (strcmp(host_str, "::") == 0)
+ strcpy(host_str, "::1");
/*
* We need to set connect_timeout otherwise on Windows
This is the main PostgreSQL git repository.
RSS Atom

AltStyle によって変換されたページ (->オリジナル) /