git.postgresql.org Git - postgresql.git/commitdiff

git projects / postgresql.git / commitdiff

Fix misleading comment in paraminfo_get_equal_hashops

author David Rowley <drowley@postgresql.org>

Mon, 7 Aug 2023 06:16:46 +0000 (18:16 +1200)

committer David Rowley <drowley@postgresql.org>

Mon, 7 Aug 2023 06:16:46 +0000 (18:16 +1200)

The comment mistakenly claimed the code was checking PlaceHolderVars for
volatile functions when the code was actually checking lateral vars.

Update the comment to reflect the reality of the code.

Author: Richard Guo
Discussion: https://postgr.es/m/CAMbWs48HZGZOV85g0fx8z1qDx6NNKHexJPT2FCnKnZhxBWkd-A@mail.gmail.com

src/backend/optimizer/path/joinpath.c patch | blob | blame | history

diff --git a/src/backend/optimizer/path/joinpath.c b/src/backend/optimizer/path/joinpath.c

index 4b58936fa4cd2151b2204a5f3a553a794a8f9a91..c1d478d2eb2cb04e383ef155aad9192b70d1ea05 100644 (file)

--- a/src/backend/optimizer/path/joinpath.c

+++ b/src/backend/optimizer/path/joinpath.c

@@ -529,7 +529,7 @@ paraminfo_get_equal_hashops(PlannerInfo *root, ParamPathInfo *param_info,

Node *expr = (Node *) lfirst(lc);

TypeCacheEntry *typentry;

- /* Reject if there are any volatile functions in PHVs */

+ /* Reject if there are any volatile functions in lateral vars */

if (contain_volatile_functions(expr))

{

list_free(*operators);

This is the main PostgreSQL git repository.

RSS Atom