git.postgresql.org Git - postgresql.git/commitdiff

git projects / postgresql.git / commitdiff

Get rid of scribbling on a const variable in psql's print.c.

2016年3月12日 23:16:24 +0000 (18:16 -0500)

Commit a2dabf0e1dda93c8 had the bright idea that it could modify a "const"
global variable if it merely casted away const from a pointer. This does
not work on platforms where the compiler puts "const" variables into
read-only storage. Depressingly, we evidently have no such platforms in
our buildfarm ... an oversight I have now remedied. (The one platform
that is known to catch this is recent OS X with -fno-common.)

Per report from Chris Ruprecht. Back-patch to 9.5 where the bogus
code was introduced.

src/bin/psql/print.c patch | blob | blame | history

src/bin/psql/print.h patch | blob | blame | history

diff --git a/src/bin/psql/print.c b/src/bin/psql/print.c

index 85dbd300d8d3b5ecdfd6225883c644688568ea22..f25a66eb36f72c6014e9b5355b5612b15b1a7aab 100644 (file)

--- a/src/bin/psql/print.c

+++ b/src/bin/psql/print.c

@@ -98,7 +98,7 @@ const printTextFormat pg_asciiformat_old =

};

/* Default unicode linestyle format */

-const printTextFormat pg_utf8format;

+printTextFormat pg_utf8format;

typedef struct unicodeStyleRowFormat