git.postgresql.org Git - postgresql.git/commitdiff

git projects / postgresql.git / commitdiff

Lock owned sequences during ALTER TABLE SET { LOGGED | UNLOGGED }.

2024年6月28日 02:21:05 +0000 (19:21 -0700)

committer Noah Misch <noah@leadboat.com>

2024年6月28日 02:21:05 +0000 (19:21 -0700)

These commands already make the persistence of owned sequences follow
owned table persistence changes. They didn't lock those sequences.
They lost the effect of nextval() calls that other sessions make after
the ALTER TABLE command, before the ALTER TABLE transaction commits.
Fix by acquiring the same lock that ALTER SEQUENCE SET { LOGGED |
UNLOGGED } acquires. This might cause more deadlocks. Back-patch to
v15, where commit 344d62fb9a978a72cf8347f0369b9ee643fd0b31 introduced
unlogged sequences.

Reviewed (in an earlier version) by Robert Haas.

Discussion: https://postgr.es/m/20240611024525.9f.nmisch@google.com

src/backend/commands/sequence.c patch | blob | blame | history

diff --git a/src/backend/commands/sequence.c b/src/backend/commands/sequence.c

index 28f85222647b067ecaab015bbf5bfb533843677d..b4ad19c05396062e2b99861d23be77ee0ec9c5e6 100644 (file)

--- a/src/backend/commands/sequence.c

+++ b/src/backend/commands/sequence.c

@@ -545,6 +545,13 @@ SequenceChangePersistence(Oid relid, char newrelpersistence)

Buffer buf;

HeapTupleData seqdatatuple;

+ /*

+ * ALTER SEQUENCE acquires this lock earlier. If we're processing an

+ * owned sequence for ALTER TABLE, lock now. Without the lock, we'd

+ * discard increments from nextval() calls (in other sessions) between

+ * this function's buffer unlock and this transaction's commit.

+ */

+ LockRelationOid(relid, AccessExclusiveLock);

init_sequence(relid, &elm, &seqrel);

/* check the comment above nextval_internal()'s equivalent call. */

This is the main PostgreSQL git repository.

RSS Atom