git.postgresql.org Git - postgresql.git/commitdiff

git projects / postgresql.git / commitdiff

Avoid rare race condition in privileges.sql regression test.

2018年10月16日 17:56:58 +0000 (13:56 -0400)

We created a temp table, then switched to a new session, leaving
the old session to clean up its temp objects in background. If that
took long enough, the eventual attempt to drop the user that owns
the temp table could fail, as exhibited today by sidewinder.
Fix by dropping the temp table explicitly when we're done with it.

It's been like this for quite some time, so back-patch to all
supported branches.

Report: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=sidewinder&dt=2018年10月16日%2014%3A45%3A00

src/test/regress/expected/privileges.out patch | blob | blame | history

src/test/regress/sql/privileges.sql patch | blob | blame | history

diff --git a/src/test/regress/expected/privileges.out b/src/test/regress/expected/privileges.out

index aebc89c1b08431b980bdb5721e5cf599cab40bac..7d5d1f0bc1ea16d5a574eec40b31699c56fbce31 100644 (file)

--- a/src/test/regress/expected/privileges.out

+++ b/src/test/regress/expected/privileges.out

@@ -1189,6 +1189,7 @@ select has_column_privilege('mytable',2::int2,'select');

(1 row)

+drop table mytable;

-- Grant options

SET SESSION AUTHORIZATION regress_priv_user1;

CREATE TABLE atest4 (a int);