git.postgresql.org Git - postgresql.git/commitdiff

git projects / postgresql.git / commitdiff

author Peter Eisentraut <peter@eisentraut.org>

2025年8月20日 16:12:08 +0000 (18:12 +0200)

committer Peter Eisentraut <peter@eisentraut.org>

2025年8月20日 16:14:24 +0000 (18:14 +0200)

In refuseDupeIndexAttach(), change from

errdetail("Another index is already attached for partition \"%s\"."...)

to

errdetail("Another index \"%s\" is already attached for partition \"%s\"."...)

so we can easily understand which index is already attached for
partition \"%s\".

Author: Jian He <jian.universality@gmail.com>
Reviewed-by: Daniel Gustafsson <daniel@yesql.se>
Reviewed-by: Peter Eisentraut <peter@eisentraut.org>
Discussion: https://www.postgresql.org/message-id/flat/CACJufxGBfykJ_1ztk9T%2BL_gLmkOSOF%2BmL9Mn4ZPydz-rh%3DLccQ%40mail.gmail.com

src/backend/commands/tablecmds.c patch | blob | blame | history

src/test/regress/expected/indexing.out patch | blob | blame | history

diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c

index c6dd2e020da23edc0d210129e3e104f64f5a8abc..082a3575d621e3e90ddb377c40a5e473e3c9f9f9 100644 (file)

--- a/src/backend/commands/tablecmds.c

+++ b/src/backend/commands/tablecmds.c

@@ -21750,7 +21750,8 @@ refuseDupeIndexAttach(Relation parentIdx, Relation partIdx, Relation partitionTb

errmsg("cannot attach index \"%s\" as a partition of index \"%s\"",

RelationGetRelationName(partIdx),

RelationGetRelationName(parentIdx)),

- errdetail("Another index is already attached for partition \"%s\".",

+ errdetail("Another index \"%s\" is already attached for partition \"%s\".",

+ get_rel_name(existingIdx),

RelationGetRelationName(partitionTbl))));

}

diff --git a/src/test/regress/expected/indexing.out b/src/test/regress/expected/indexing.out

index bcf1db11d731d0062ae8d6ef45e49d5ab2452939..4d29fb85293e0a657b3e4ac79649c162d0868d5a 100644 (file)

--- a/src/test/regress/expected/indexing.out

+++ b/src/test/regress/expected/indexing.out

@@ -248,7 +248,7 @@ alter index idxpart_a_b_idx attach partition idxpart1_a_b_idx; -- quiet

create index idxpart1_2_a_b on idxpart1 (a, b);

alter index idxpart_a_b_idx attach partition idxpart1_2_a_b;

ERROR: cannot attach index "idxpart1_2_a_b" as a partition of index "idxpart_a_b_idx"

-DETAIL: Another index is already attached for partition "idxpart1".

+DETAIL: Another index "idxpart1_a_b_idx" is already attached for partition "idxpart1".

drop table idxpart;

-- make sure everything's gone

select indexrelid::regclass, indrelid::regclass

This is the main PostgreSQL git repository.

RSS Atom