git.postgresql.org Git - postgresql.git/commitdiff

git projects / postgresql.git / commitdiff

Don't listen to localhost in ssl_passphrase_callback test

author Andrew Dunstan <andrew@dunslane.net>

2020年3月26日 01:14:14 +0000 (21:14 -0400)

committer Andrew Dunstan <andrew@dunslane.net>

2020年3月26日 01:14:14 +0000 (21:14 -0400)

Commit 896fcdb230 contained an unnecessary setting that listened to
localhost. Since the test doesn't actually try to make an SSL connection
to the database this isn't required. Moreover, it's a security hole.

Per gripe from Tom Lane.

src/test/modules/ssl_passphrase_callback/t/001_testfunc.pl patch | blob | blame | history

diff --git a/src/test/modules/ssl_passphrase_callback/t/001_testfunc.pl b/src/test/modules/ssl_passphrase_callback/t/001_testfunc.pl

index c052d72f9cdd00f3e2dc79d2ac7c4a107d4909dd..8d135d2495f499572663119521d5250d81e437d7 100644 (file)

--- a/src/test/modules/ssl_passphrase_callback/t/001_testfunc.pl

+++ b/src/test/modules/ssl_passphrase_callback/t/001_testfunc.pl

@@ -28,7 +28,6 @@ $node->append_conf('postgresql.conf',

"ssl_passphrase.passphrase = '$rot13pass'");

$node->append_conf('postgresql.conf',

"shared_preload_libraries = 'ssl_passphrase_func'");

-$node->append_conf('postgresql.conf', "listen_addresses = 'localhost'");

$node->append_conf('postgresql.conf', "ssl = 'on'");

my $ddir = $node->data_dir;

This is the main PostgreSQL git repository.

RSS Atom