index 8fcb188323425a931006b2a079b76f3fc3b31502..9e9dc5c2c13ad37c5c4c40b4abe64e1a62af011f 100644 (file)
@@ -1273,7 +1273,9 @@ DefineRelation(CreateStmt *stmt, char relkind, Oid ownerId,
*
* Given a list of ColumnDef nodes, build a TupleDesc.
*
- * Note: tdtypeid will need to be filled in later on.
+ * Note: This is only for the limited purpose of table and view creation. Not
+ * everything is filled in. A real tuple descriptor should be obtained from
+ * the relcache.
*/
TupleDesc
BuildDescForRelation(const List *columns)
AttrNumber attnum;
ListCell *l;
TupleDesc desc;
- bool has_not_null;
char *attname;
Oid atttypid;
int32 atttypmod;
*/
natts = list_length(columns);
desc = CreateTemplateTupleDesc(natts);
- has_not_null = false;
attnum = 0;
/* Fill in additional stuff not handled by TupleDescInitEntry */
att->attnotnull = entry->is_not_null;
- has_not_null |= entry->is_not_null;
att->attislocal = entry->is_local;
att->attinhcount = entry->inhcount;
att->attidentity = entry->identity;
att->attstorage = GetAttributeStorage(att->atttypid, entry->storage_name);
}
- if (has_not_null)
- {
- TupleConstr *constr = (TupleConstr *) palloc0(sizeof(TupleConstr));
-
- constr->has_not_null = true;
- constr->has_generated_stored = false;
- constr->defval = NULL;
- constr->missing = NULL;
- constr->num_defval = 0;
- constr->check = NULL;
- constr->num_check = 0;
- desc->constr = constr;
- }
- else
- {
- desc->constr = NULL;
- }
-
return desc;
}