git.postgresql.org Git - postgresql.git/commitdiff

git projects / postgresql.git / commitdiff

2014年4月23日 03:22:12 +0000 (23:22 -0400)

Some ancient comments claimed that fn_nargs could be -1 to indicate a
variable number of input arguments; but this was never implemented, and
is at variance with what we ultimately did with "variadic" functions.
Update the comments.

src/backend/utils/fmgr/README patch | blob | blame | history

src/include/fmgr.h patch | blob | blame | history

diff --git a/src/backend/utils/fmgr/README b/src/backend/utils/fmgr/README

index a650eb14a370bbe07f077fb65b319cd7be161efb..e7e7ae9c6e862548ae9cb28f3b3d14dfa167b431 100644 (file)

--- a/src/backend/utils/fmgr/README

+++ b/src/backend/utils/fmgr/README

@@ -67,7 +67,7 @@ typedef struct

{

PGFunction fn_addr; /* pointer to function or handler to be called */

Oid fn_oid; /* OID of function (NOT of handler, if any) */

- short fn_nargs; /* 0..FUNC_MAX_ARGS, or -1 if variable arg count */

+ short fn_nargs; /* number of input args (0..FUNC_MAX_ARGS) */

bool fn_strict; /* function is "strict" (NULL in => NULL out) */

bool fn_retset; /* function returns a set (over multiple calls) */

unsigned char fn_stats; /* collect stats if track_functions > this */

diff --git a/src/include/fmgr.h b/src/include/fmgr.h

index 494c768826b8b51582ad497fa74a3e88f4f670fe..22539eecb6088e1cbe402ffdaf3078647ea31e77 100644 (file)

--- a/src/include/fmgr.h

+++ b/src/include/fmgr.h

@@ -54,8 +54,7 @@ typedef struct FmgrInfo

{

PGFunction fn_addr; /* pointer to function or handler to be called */

Oid fn_oid; /* OID of function (NOT of handler, if any) */

- short fn_nargs; /* 0..FUNC_MAX_ARGS, or -1 if variable arg

- * count */

+ short fn_nargs; /* number of input args (0..FUNC_MAX_ARGS) */

bool fn_strict; /* function is "strict" (NULL in => NULL out) */

bool fn_retset; /* function returns a set */

unsigned char fn_stats; /* collect stats if track_functions > this */

This is the main PostgreSQL git repository.

RSS Atom