git.postgresql.org Git - postgresql.git/commitdiff

git projects / postgresql.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 3af0d17)
Remove NOT_USED BufFileTellBlock() from buffile.c
2023年11月17日 01:46:50 +0000 (10:46 +0900)
2023年11月17日 01:46:50 +0000 (10:46 +0900)
This routine has been marked as NOT_USED since 20ad43b576d9 from 2000,
and a patch is planned to switch the logtape/tuplestore APIs to rely on
int64 rather than long for the block nunbers, which is more portable.

Keeping it is more confusing than anything at this stage, so let's get
rid of it entirely.

Thanks for Heikki Linnakangas for the poke on this one.

Discussion: https://postgr.es/m/5047be8c-7ee6-4dd5-af76-6c916c3103b4@iki.fi


diff --git a/src/backend/storage/file/buffile.c b/src/backend/storage/file/buffile.c
index 41ab64100e3b273319725121d04d14e52b018513..d3f0f58858021cbae0308b851472b0e4ef3649ae 100644 (file)
--- a/src/backend/storage/file/buffile.c
+++ b/src/backend/storage/file/buffile.c
@@ -856,24 +856,6 @@ BufFileSeekBlock(BufFile *file, long blknum)
SEEK_SET);
}
-#ifdef NOT_USED
-/*
- * BufFileTellBlock --- block-oriented tell
- *
- * Any fractional part of a block in the current seek position is ignored.
- */
-long
-BufFileTellBlock(BufFile *file)
-{
- long blknum;
-
- blknum = (file->curOffset + file->pos) / BLCKSZ;
- blknum += file->curFile * BUFFILE_SEG_SIZE;
- return blknum;
-}
-
-#endif
-
/*
* Return the current fileset based BufFile size.
*
This is the main PostgreSQL git repository.
RSS Atom

AltStyle によって変換されたページ (->オリジナル) /