git.postgresql.org Git - postgresql.git/commitdiff

git projects / postgresql.git / commitdiff

Don't try to test files named with a trailing dot on Windows

author Andrew Dunstan <andrew@dunslane.net>

2018年10月21日 13:00:13 +0000 (09:00 -0400)

committer Andrew Dunstan <andrew@dunslane.net>

2018年10月21日 13:00:13 +0000 (09:00 -0400)

The pg_verify_checksums test tries to create files with corrupt data
named "123." and "123_." But on Windows a file name with a trailing dot
is the same as a file without the trailing dot. In the first case this
will create a file with a "valid" name, which causes the test to fail in
an unexpected way, and in the secongd case this will be redandant as the
test already creates a file named "123_".

Bug discovered by buildfarm animal bowerbird.

src/bin/pg_verify_checksums/t/002_actions.pl patch | blob | blame | history

diff --git a/src/bin/pg_verify_checksums/t/002_actions.pl b/src/bin/pg_verify_checksums/t/002_actions.pl

index ff4772708b52b11604f2ec64004415d8d94fb27b..d59970b7350ec5a40dae55c002f1887152ad545e 100644 (file)

--- a/src/bin/pg_verify_checksums/t/002_actions.pl

+++ b/src/bin/pg_verify_checksums/t/002_actions.pl

@@ -19,9 +19,11 @@ command_like(['pg_controldata', $pgdata],

# Add set of dummy files with some contents. These should not be scanned

# by the tool.

-append_to_file "$pgdata/global/123.", "foo";

+# On Windows, file name "foo." == "foo", so skip that pattern there.

+append_to_file "$pgdata/global/123.", "foo" unless $windows_os;

append_to_file "$pgdata/global/123_", "foo";