The use of pg_atoi() for parsing a string into an Oid fails for values
larger than INT32_MAX, since OIDs are unsigned. Instead, use
atooid(). While this has less error checking, the contents of the
data directory are expected to be trustworthy, so we don't need to go
out of our way to do full error checking.
Discussion: https://www.postgresql.org/message-id/flat/
dea47fc8-6c89-a2b1-07e3-
754ff1ab094b%402ndquadrant.com
index a73893237a4e9148ddf397f8ac9698f46419723f..a1c005157b5dfe10f364ca9273ff7d743df13273 100644 (file)
@@ -1316,7 +1316,7 @@ sendDir(const char *path, int basepathlen, bool sizeonly, List *tablespaces,
if (!sizeonly)
sent = sendFile(pathbuf, pathbuf + basepathlen + 1, &statbuf,
- true, isDbDir ? pg_atoi(lastDir + 1, sizeof(Oid), 0) : InvalidOid);
+ true, isDbDir ? atooid(lastDir + 1) : InvalidOid);
if (sent || sizeonly)
{