git.postgresql.org Git - postgresql.git/commitdiff

git projects / postgresql.git / commitdiff

Disable parallel query in psql error-with-FETCH_COUNT test.

Sun, 7 Apr 2024 01:49:24 +0000 (21:49 -0400)

The buildfarm members using debug_parallel_query = regress are mostly
unhappy with this test. I guess what is happening is that rows
generated by a parallel worker are buffered, and might or might not
get to the leader before the expected error occurs. We did not see
any variability in the old version of this test because each FETCH
would succeed or fail atomically, leading to a predictable number of
rows emitted before failure. I don't find this to be a bug, just
unspecified behavior, so let's disable parallel query for this one
test case to make the results stable.

src/test/regress/expected/psql.out patch | blob | blame | history

src/test/regress/sql/psql.sql patch | blob | blame | history

diff --git a/src/test/regress/expected/psql.out b/src/test/regress/expected/psql.out

index 0b8dd7abf2df63745911399b22df089920655dac..3bbe4c5f974d6fd70888e307ccbb63f2cbb2a144 100644 (file)

--- a/src/test/regress/expected/psql.out

+++ b/src/test/regress/expected/psql.out

@@ -4788,6 +4788,8 @@ error code: 00000

\echo 'number of rows:' :ROW_COUNT

number of rows: 19

-- chunked results with an error after the first chunk

+-- (we must disable parallel query here, else the behavior is timing-dependent)

+set debug_parallel_query = off;