git.postgresql.org Git - postgresql.git/commitdiff

git projects / postgresql.git / commitdiff

Remove two_phase variable from CreateReplicationSlotCmd struct.

author Amit Kapila <akapila@postgresql.org>

Mon, 7 Jun 2021 04:02:06 +0000 (09:32 +0530)

committer Amit Kapila <akapila@postgresql.org>

Mon, 7 Jun 2021 04:02:06 +0000 (09:32 +0530)

Commit 19890a064e added the option to enable two_phase commits via
pg_create_logical_replication_slot but didn't extend the support of same
in replication protocol. However, by mistake, it added the two_phase
variable in CreateReplicationSlotCmd which is required only when we extend
the replication protocol.

Reported-by: Jeff Davis
Author: Ajin Cherian
Reviewed-by: Amit Kapila
Discussion: https://postgr.es/m/64b9f783c6e125f18f88fbc0c0234e34e71d8639.camel@j-davis.com

src/backend/replication/walsender.c patch | blob | blame | history

src/include/nodes/replnodes.h patch | blob | blame | history

diff --git a/src/backend/replication/walsender.c b/src/backend/replication/walsender.c

index e94069c366a36e430e236946994b4c2bc1705f09..109c723f4e1e7ac166b62c745382b90e0936e698 100644 (file)

--- a/src/backend/replication/walsender.c

+++ b/src/backend/replication/walsender.c

@@ -954,7 +954,7 @@ CreateReplicationSlot(CreateReplicationSlotCmd *cmd)

ReplicationSlotCreate(cmd->slotname, true,

cmd->temporary ? RS_TEMPORARY : RS_EPHEMERAL,

- cmd->two_phase);

+ false);

}