git.postgresql.org Git - postgresql.git/commitdiff

git projects / postgresql.git / commitdiff

Flush logical mapping files with fd opened for read/write at checkpoint

author Michael Paquier <michael@paquier.xyz>

Wed, 9 Oct 2019 04:30:43 +0000 (13:30 +0900)

committer Michael Paquier <michael@paquier.xyz>

Wed, 9 Oct 2019 04:30:43 +0000 (13:30 +0900)

The file descriptor was opened with read-only to fsync a regular file,
which would cause EBADFD errors on some platforms.

This is similar to the recent fix done by a586cc4b (which was broken by
me with 82a5649), except that I noticed this issue while monitoring the
backend code for similar mistakes. Backpatch to 9.4, as this has been
introduced since logical decoding exists as of b89e151.

Author: Michael Paquier
Reviewed-by: Andres Freund
Discussion: https://postgr.es/m/20191006045548.GA14532@paquier.xyz
Backpatch-through: 9.4

src/backend/access/heap/rewriteheap.c patch | blob | blame | history

diff --git a/src/backend/access/heap/rewriteheap.c b/src/backend/access/heap/rewriteheap.c

index 7c98a42b8ba8a92abcd7fdd384b5a8c459590c5c..306e74ea103c1dd8a8568cf4416c0e35a41f06de 100644 (file)

--- a/src/backend/access/heap/rewriteheap.c

+++ b/src/backend/access/heap/rewriteheap.c

@@ -1280,7 +1280,8 @@ CheckPointLogicalRewriteHeap(void)

}

else

{

- int fd = OpenTransientFile(path, O_RDONLY | PG_BINARY);

+ /* on some operating systems fsyncing a file requires O_RDWR */

+ int fd = OpenTransientFile(path, O_RDWR | PG_BINARY);

* The file cannot vanish due to concurrency since this function

This is the main PostgreSQL git repository.

RSS Atom