git.postgresql.org Git - postgresql.git/commitdiff

git projects / postgresql.git / commitdiff

Repair remarkably-inefficient query for dumping large object comments: it

Fri, 9 Jun 2006 19:46:09 +0000 (19:46 +0000)

was invoking obj_description() for each large object chunk, instead of once
per large object. This code is new as of 8.1, which may explain why the
problem hadn't been noticed already.

src/bin/pg_dump/pg_dump.c patch | blob | blame | history

diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c

index 2f30b17428f90ae49e2bf4bdad81c9a25effb89d..4f76eae1468bbbd8d6dbf60d532213bbf45cc486 100644 (file)

--- a/src/bin/pg_dump/pg_dump.c

+++ b/src/bin/pg_dump/pg_dump.c

@@ -12,7 +12,7 @@

* by PostgreSQL

* IDENTIFICATION

- * $PostgreSQL: pgsql/src/bin/pg_dump/pg_dump.c,v 1.437 2006年06月07日 22:24:45 momjian Exp $

+ * $PostgreSQL: pgsql/src/bin/pg_dump/pg_dump.c,v 1.438 2006年06月09日 19:46:09 tgl Exp $

*-------------------------------------------------------------------------

@@ -1575,9 +1575,9 @@ dumpBlobComments(Archive *AH, void *arg)

/* Cursor to get all BLOB comments */

if (AH->remoteVersion >= 70200)

- blobQry = "DECLARE blobcmt CURSOR FOR SELECT DISTINCT loid, obj_description(loid, 'pg_largeobject') FROM pg_largeobject";

+ blobQry = "DECLARE blobcmt CURSOR FOR SELECT loid, obj_description(loid, 'pg_largeobject') FROM (SELECT DISTINCT loid FROM pg_largeobject) ss";

else if (AH->remoteVersion >= 70100)

- blobQry = "DECLARE blobcmt CURSOR FOR SELECT DISTINCT loid, obj_description(loid) FROM pg_largeobject";

+ blobQry = "DECLARE blobcmt CURSOR FOR SELECT loid, obj_description(loid) FROM (SELECT DISTINCT loid FROM pg_largeobject) ss";

else

blobQry = "DECLARE blobcmt CURSOR FOR SELECT oid, (SELECT description FROM pg_description pd WHERE pd.objoid=pc.oid) FROM pg_class pc WHERE relkind = 'l'";

This is the main PostgreSQL git repository.

RSS Atom