git.postgresql.org Git - postgresql.git/commitdiff

git projects / postgresql.git / commitdiff

Mon, 2 Apr 2018 17:46:13 +0000 (13:46 -0400)

Mon, 2 Apr 2018 17:46:21 +0000 (13:46 -0400)

Coverity complained about possible buffer overrun in two places added by
commit 1eb6d6527, and AFAICS it's reasonable to worry: even granting that
the WAL originator properly truncated the commit GID to GIDSIZE, we should
not really bet our lives on that having the same value as it does in the
current build. Hence, use strlcpy() not strcpy(), and adjust the pointer
advancement logic to be sure we skip over the whole source string even if
strlcpy() truncated it.

src/backend/access/rmgrdesc/xactdesc.c patch | blob | blame | history

diff --git a/src/backend/access/rmgrdesc/xactdesc.c b/src/backend/access/rmgrdesc/xactdesc.c

index b3e2fc3036c4a025e8aeb61052fb158da4d10e8f..3b3c95f8104c27b9a7426723a4e9be2e9956eec7 100644 (file)

--- a/src/backend/access/rmgrdesc/xactdesc.c

+++ b/src/backend/access/rmgrdesc/xactdesc.c

@@ -106,8 +106,8 @@ ParseCommitRecord(uint8 info, xl_xact_commit *xlrec, xl_xact_parsed_commit *pars

if (parsed->xinfo & XACT_XINFO_HAS_GID)

{

int gidlen;

- strcpy(parsed->twophase_gid, data);

- gidlen = strlen(parsed->twophase_gid) + 1;

+ strlcpy(parsed->twophase_gid, data, sizeof(parsed->twophase_gid));