git.postgresql.org Git - postgresql.git/commitdiff

git projects / postgresql.git / commitdiff

Fix test_decoding test case's check that slot has been dropped.

author Heikki Linnakangas <heikki.linnakangas@iki.fi>

2014年5月16日 08:23:17 +0000 (11:23 +0300)

committer Heikki Linnakangas <heikki.linnakangas@iki.fi>

2014年5月16日 08:34:46 +0000 (11:34 +0300)

pg_stat_replication shows connected replication clients. The ddl test case
never has any replication clients connected, so querying pg_stat_replication
is pointless. To check that a slot has been dropped correctly, query
pg_replication_slots instead.

Andres Freund

contrib/test_decoding/expected/ddl.out patch | blob | blame | history

contrib/test_decoding/sql/ddl.sql patch | blob | blame | history

diff --git a/contrib/test_decoding/expected/ddl.out b/contrib/test_decoding/expected/ddl.out

index 05a4bd3f7ed026ec99eb4070f0703bc1c12965f5..e13a6c737059ea68f1124771042178409454ba21 100644 (file)

--- a/contrib/test_decoding/expected/ddl.out

+++ b/contrib/test_decoding/expected/ddl.out

@@ -639,9 +639,9 @@ SELECT pg_drop_replication_slot('regression_slot');

(1 row)

-/* check that we aren't visible anymore now */

-SELECT * FROM pg_stat_replication;

------+----------+---------+------------------+-------------+-----------------+-------------+---------------+--------------+-------+---------------+----------------+----------------+-----------------+---------------+------------

+/* check that the slot is gone */

+SELECT * FROM pg_replication_slots;

+-----------+--------+-----------+--------+----------+--------+------+--------------+-------------

(0 rows)

diff --git a/contrib/test_decoding/sql/ddl.sql b/contrib/test_decoding/sql/ddl.sql

index 555a59c5adfc10824a6a5894f93b29787cd6cbe6..87e74c64f31cde7a2088cb51eeb599c5ed6e684a 100644 (file)

--- a/contrib/test_decoding/sql/ddl.sql

+++ b/contrib/test_decoding/sql/ddl.sql

@@ -331,7 +331,8 @@ SELECT data FROM pg_logical_slot_get_changes('regression_slot', NULL, NULL, 'inc

-- done, free logical replication slot

SELECT data FROM pg_logical_slot_get_changes('regression_slot', NULL, NULL, 'include-xids', '0');

SELECT pg_drop_replication_slot('regression_slot');

-/* check that we aren't visible anymore now */

-SELECT * FROM pg_stat_replication;

+/* check that the slot is gone */

+SELECT * FROM pg_replication_slots;

This is the main PostgreSQL git repository.

RSS Atom