git.postgresql.org Git - postgresql.git/commitdiff

git projects / postgresql.git / commitdiff

Add regression tests for ALTER MATERIALIZED VIEW with tablespaces

author Michael Paquier <michael@paquier.xyz>

2022年3月19日 08:28:50 +0000 (17:28 +0900)

committer Michael Paquier <michael@paquier.xyz>

2022年3月19日 08:28:50 +0000 (17:28 +0900)

The clauses SET TABLESPACE and ALL IN TABLESPACE are supported in ALTER
MATERIALIZED VIEW for a long time, and they behave mostly like ALTER
TABLE by reusing the same code paths, but there were zero tests for
them. This commit closes the gap with new tests in tablespace.sql.

Author: Yugo Nagata
Discussion: https://postgr.es/m/20220316133337.5dc9740abfa24c25ec9f67f5@sraoss.co.jp

src/test/regress/expected/tablespace.out patch | blob | blame | history

src/test/regress/sql/tablespace.sql patch | blob | blame | history

diff --git a/src/test/regress/expected/tablespace.out b/src/test/regress/expected/tablespace.out

index 473fe8c28e0797e03324b526bde16612c12c87b3..c52cf1cfcf91969224ce5fc97ac6b5a3d9504dc9 100644 (file)

--- a/src/test/regress/expected/tablespace.out

+++ b/src/test/regress/expected/tablespace.out

@@ -905,6 +905,16 @@ SELECT COUNT(*) FROM testschema.atable; -- checks heap

(1 row)

+-- let's try moving a materialized view from one place to another

+CREATE MATERIALIZED VIEW testschema.amv AS SELECT * FROM testschema.atable;

+ALTER MATERIALIZED VIEW testschema.amv SET TABLESPACE regress_tblspace;

+REFRESH MATERIALIZED VIEW testschema.amv;

+SELECT COUNT(*) FROM testschema.amv;

+ count

+-------

+ 3

+(1 row)

-- Will fail with bad path

CREATE TABLESPACE regress_badspace LOCATION '/no/such/location';

ERROR: directory "/no/such/location" does not exist

@@ -939,18 +949,22 @@ RESET ROLE;

ALTER TABLESPACE regress_tblspace RENAME TO regress_tblspace_renamed;

ALTER TABLE ALL IN TABLESPACE regress_tblspace_renamed SET TABLESPACE pg_default;

ALTER INDEX ALL IN TABLESPACE regress_tblspace_renamed SET TABLESPACE pg_default;

+ALTER MATERIALIZED VIEW ALL IN TABLESPACE regress_tblspace_renamed SET TABLESPACE pg_default;

-- Should show notice that nothing was done

ALTER TABLE ALL IN TABLESPACE regress_tblspace_renamed SET TABLESPACE pg_default;

NOTICE: no matching relations in tablespace "regress_tblspace_renamed" found

+ALTER MATERIALIZED VIEW ALL IN TABLESPACE regress_tblspace_renamed SET TABLESPACE pg_default;

+NOTICE: no matching relations in tablespace "regress_tblspace_renamed" found

-- Should succeed

DROP TABLESPACE regress_tblspace_renamed;

DROP SCHEMA testschema CASCADE;

-NOTICE: drop cascades to 6 other objects

+NOTICE: drop cascades to 7 other objects

DETAIL: drop cascades to table testschema.foo

drop cascades to table testschema.asselect

drop cascades to table testschema.asexecute

drop cascades to table testschema.part

drop cascades to table testschema.atable

+drop cascades to materialized view testschema.amv

drop cascades to table testschema.tablespace_acl

DROP ROLE regress_tablespace_user1;

DROP ROLE regress_tablespace_user2;

diff --git a/src/test/regress/sql/tablespace.sql b/src/test/regress/sql/tablespace.sql

index 0949a28488d8b3b43b2c07be30760c87b74427ab..21db433f2a8ef1335e56df431c2dbdddf2e2fcac 100644 (file)

--- a/src/test/regress/sql/tablespace.sql

+++ b/src/test/regress/sql/tablespace.sql

@@ -380,6 +380,12 @@ INSERT INTO testschema.atable VALUES(3); -- ok

INSERT INTO testschema.atable VALUES(1); -- fail (checks index)

SELECT COUNT(*) FROM testschema.atable; -- checks heap

+-- let's try moving a materialized view from one place to another

+CREATE MATERIALIZED VIEW testschema.amv AS SELECT * FROM testschema.atable;

+ALTER MATERIALIZED VIEW testschema.amv SET TABLESPACE regress_tblspace;

+REFRESH MATERIALIZED VIEW testschema.amv;

+SELECT COUNT(*) FROM testschema.amv;

-- Will fail with bad path

CREATE TABLESPACE regress_badspace LOCATION '/no/such/location';

@@ -414,9 +420,11 @@ ALTER TABLESPACE regress_tblspace RENAME TO regress_tblspace_renamed;

ALTER TABLE ALL IN TABLESPACE regress_tblspace_renamed SET TABLESPACE pg_default;

ALTER INDEX ALL IN TABLESPACE regress_tblspace_renamed SET TABLESPACE pg_default;

+ALTER MATERIALIZED VIEW ALL IN TABLESPACE regress_tblspace_renamed SET TABLESPACE pg_default;

-- Should show notice that nothing was done

ALTER TABLE ALL IN TABLESPACE regress_tblspace_renamed SET TABLESPACE pg_default;

+ALTER MATERIALIZED VIEW ALL IN TABLESPACE regress_tblspace_renamed SET TABLESPACE pg_default;

-- Should succeed

DROP TABLESPACE regress_tblspace_renamed;

This is the main PostgreSQL git repository.

RSS Atom