git.postgresql.org Git - postgresql.git/commitdiff

git projects / postgresql.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: b61a5c4)
Rewrite previous commit's test for TestUpgradeXversion compatibility.
author Noah Misch <noah@leadboat.com>
2025年8月23日 23:46:20 +0000 (16:46 -0700)
committer Noah Misch <noah@leadboat.com>
2025年8月23日 23:46:20 +0000 (16:46 -0700)
v17 introduced the MAINTAIN ON TABLES privilege. That changed the
applicable "baseacls" reaching buildACLCommands(). That yielded
spurious TestUpgradeXversion diffs. Change to use a TYPES privilege.
Types have the same one privilege in all supported versions, so they
avoid the problem. Per buildfarm. Back-patch to v13, like that commit.

Discussion: https://postgr.es/m/20250823144505.88.nmisch@google.com
Backpatch-through: 13

src/test/regress/expected/privileges.out patch | blob | blame | history
src/test/regress/sql/privileges.sql patch | blob | blame | history

diff --git a/src/test/regress/expected/privileges.out b/src/test/regress/expected/privileges.out
index 8149666725b43b19b07d16c5c12c205ca4e628d9..6dcc95ede502ccb838b3b3dcc11fe8b51c618457 100644 (file)
--- a/src/test/regress/expected/privileges.out
+++ b/src/test/regress/expected/privileges.out
@@ -3155,9 +3155,9 @@ DROP USER regress_priv_user8; -- does not exist
ERROR: role "regress_priv_user8" does not exist
-- leave some default ACLs for pg_upgrade's dump-restore test input.
ALTER DEFAULT PRIVILEGES FOR ROLE pg_signal_backend
- REVOKE INSERT ON TABLES FROM pg_signal_backend;
+ REVOKE USAGE ON TYPES FROM pg_signal_backend;
ALTER DEFAULT PRIVILEGES FOR ROLE pg_read_all_settings
- REVOKE INSERT ON TABLES FROM pg_read_all_settings;
+ REVOKE USAGE ON TYPES FROM pg_read_all_settings;
-- permissions with LOCK TABLE
CREATE USER regress_locktable_user;
CREATE TABLE lock_table (a int);
diff --git a/src/test/regress/sql/privileges.sql b/src/test/regress/sql/privileges.sql
index 7b1e9393577ec83d6fd818a0c5dee4c5816b65bc..fe409654c0e981ce09388e11c9b3e78263a28f6e 100644 (file)
--- a/src/test/regress/sql/privileges.sql
+++ b/src/test/regress/sql/privileges.sql
@@ -1865,9 +1865,9 @@ DROP USER regress_priv_user8; -- does not exist
-- leave some default ACLs for pg_upgrade's dump-restore test input.
ALTER DEFAULT PRIVILEGES FOR ROLE pg_signal_backend
- REVOKE INSERT ON TABLES FROM pg_signal_backend;
+ REVOKE USAGE ON TYPES FROM pg_signal_backend;
ALTER DEFAULT PRIVILEGES FOR ROLE pg_read_all_settings
- REVOKE INSERT ON TABLES FROM pg_read_all_settings;
+ REVOKE USAGE ON TYPES FROM pg_read_all_settings;
-- permissions with LOCK TABLE
This is the main PostgreSQL git repository.
RSS Atom

AltStyle によって変換されたページ (->オリジナル) /