git.postgresql.org Git - postgresql.git/commitdiff

git projects / postgresql.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 0db2fc9)
Fix perlcritic warnings
2018年2月22日 20:13:57 +0000 (15:13 -0500)
2018年2月22日 20:13:57 +0000 (15:13 -0500)

diff --git a/src/bin/pgbench/t/001_pgbench_with_server.pl b/src/bin/pgbench/t/001_pgbench_with_server.pl
index 99286f6bc0c3e8200a8f7acf75754d54c3a9d779..e585220dc088fd7ee948415149042928245b4503 100644 (file)
--- a/src/bin/pgbench/t/001_pgbench_with_server.pl
+++ b/src/bin/pgbench/t/001_pgbench_with_server.pl
@@ -584,7 +584,7 @@ sub check_pgbench_logs
{
my ($prefix, $nb, $min, $max, $re) = @_;
- my @logs = <$prefix.*>;
+ my @logs = glob "$prefix.*";
ok(@logs == $nb, "number of log files");
ok(grep(/^$prefix\.\d+(\.\d+)?$/, @logs) == $nb, "file name format");
@@ -592,14 +592,14 @@ sub check_pgbench_logs
for my $log (sort @logs)
{
eval {
- open LOG, $log or die "$@";
- my @contents = <LOG>;
+ open my $fh, '<', $log or die "$@";
+ my @contents = <$fh>;
my $clen = @contents;
ok( $min <= $clen && $clen <= $max,
"transaction count for $log ($clen)");
ok( grep($re, @contents) == $clen,
"transaction format for $prefix");
- close LOG or die "$@";
+ close $fh or die "$@";
};
}
ok(unlink(@logs), "remove log files");
This is the main PostgreSQL git repository.
RSS Atom

AltStyle によって変換されたページ (->オリジナル) /