git.postgresql.org Git - postgresql.git/commitdiff

git projects / postgresql.git / commitdiff

Expose the "*VALUES*" alias that we generate for a stand-alone VALUES list.

Sat, 4 Jun 2011 19:48:25 +0000 (15:48 -0400)

We were trying to make that strictly an internal implementation detail,
but it turns out that it's exposed anyway when dumping a view defined
like
CREATE VIEW test_view AS VALUES (1), (2), (3) ORDER BY 1;
This comes out as
CREATE VIEW ... ORDER BY "*VALUES*".column1;
which fails to parse when reloading the dump.

Hacking ruleutils.c to suppress the column qualification looks like it'd
be a risky business, so instead promote the RTE alias to full-fledged
usability.

Per bug #6049 from Dylan Adams. Back-patch to all supported branches.

src/backend/parser/analyze.c patch | blob | blame | history

diff --git a/src/backend/parser/analyze.c b/src/backend/parser/analyze.c

index 70cdb593f738905e1d6a943477ca23e1c5dbe154..4e83e145299e7aec6f73a509f42a7f5edd68d76c 100644 (file)

--- a/src/backend/parser/analyze.c

+++ b/src/backend/parser/analyze.c

@@ -909,7 +909,7 @@ transformSelectStmt(ParseState *pstate, SelectStmt *stmt)

* transforms a VALUES clause that's being used as a standalone SELECT

* We build a Query containing a VALUES RTE, rather as if one had written

- * SELECT * FROM (VALUES ...)

+ * SELECT * FROM (VALUES ...) AS "*VALUES*"

static Query *

transformValuesClause(ParseState *pstate, SelectStmt *stmt)