git.postgresql.org Git - postgresql.git/commitdiff

git projects / postgresql.git / commitdiff

Add missing BUFFERS OFF in regression tests, take 2

author David Rowley <drowley@postgresql.org>

2024年12月11日 10:16:44 +0000 (23:16 +1300)

committer David Rowley <drowley@postgresql.org>

2024年12月11日 10:16:44 +0000 (23:16 +1300)

Similar to 9fa1aaa65, but running with -D RELCACHE_FORCE_RELEASE and
-D CATCACHE_FORCE_RELEASE yielded some additional missing places that
needed BUFFERS OFF.

Discussion: https://postgr.es/m/CANNMO++W7MM8T0KyXN3ZheXXt-uLVM3aEtZd+WNfZ=obxffUiA@mail.gmail.com

src/test/regress/expected/matview.out patch | blob | blame | history

src/test/regress/expected/misc_functions.out patch | blob | blame | history

src/test/regress/sql/matview.sql patch | blob | blame | history

src/test/regress/sql/misc_functions.sql patch | blob | blame | history

diff --git a/src/test/regress/expected/matview.out b/src/test/regress/expected/matview.out

index 038ab735176ea0adb7a8a93656dae294a406be65..9eab51bc2a6b82ef520e1930e21c7cb35e8407df 100644 (file)

--- a/src/test/regress/expected/matview.out

+++ b/src/test/regress/expected/matview.out

@@ -624,7 +624,7 @@ GRANT ALL ON SCHEMA matview_schema TO public;

SET SESSION AUTHORIZATION regress_matview_user;

CREATE MATERIALIZED VIEW matview_schema.mv_withdata1 (a) AS

SELECT generate_series(1, 10) WITH DATA;

-EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF)

+EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF)

CREATE MATERIALIZED VIEW matview_schema.mv_withdata2 (a) AS

SELECT generate_series(1, 10) WITH DATA;

QUERY PLAN

@@ -636,7 +636,7 @@ EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF)

REFRESH MATERIALIZED VIEW matview_schema.mv_withdata2;

CREATE MATERIALIZED VIEW matview_schema.mv_nodata1 (a) AS

SELECT generate_series(1, 10) WITH NO DATA;

-EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF)

+EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF)

CREATE MATERIALIZED VIEW matview_schema.mv_nodata2 (a) AS

SELECT generate_series(1, 10) WITH NO DATA;

QUERY PLAN

@@ -669,11 +669,11 @@ ERROR: relation "matview_ine_tab" already exists

CREATE MATERIALIZED VIEW IF NOT EXISTS matview_ine_tab AS

SELECT 1 / 0 WITH NO DATA; -- ok

NOTICE: relation "matview_ine_tab" already exists, skipping

-EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF)

+EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF)

CREATE MATERIALIZED VIEW matview_ine_tab AS

SELECT 1 / 0; -- error

ERROR: relation "matview_ine_tab" already exists

-EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF)

+EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF)

CREATE MATERIALIZED VIEW IF NOT EXISTS matview_ine_tab AS

SELECT 1 / 0; -- ok

NOTICE: relation "matview_ine_tab" already exists, skipping

@@ -681,11 +681,11 @@ NOTICE: relation "matview_ine_tab" already exists, skipping

------------

(0 rows)

-EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF)

+EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF)

CREATE MATERIALIZED VIEW matview_ine_tab AS

SELECT 1 / 0 WITH NO DATA; -- error

ERROR: relation "matview_ine_tab" already exists

-EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF)

+EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF)

CREATE MATERIALIZED VIEW IF NOT EXISTS matview_ine_tab AS

SELECT 1 / 0 WITH NO DATA; -- ok

NOTICE: relation "matview_ine_tab" already exists, skipping

diff --git a/src/test/regress/expected/misc_functions.out b/src/test/regress/expected/misc_functions.out

index 8c73d2b621e462762f09e98a3b803e8fae388ef1..384e751663abc3e680611e9243a01352abcd820e 100644 (file)

--- a/src/test/regress/expected/misc_functions.out

+++ b/src/test/regress/expected/misc_functions.out

@@ -22,7 +22,7 @@ BEGIN

SET LOCAL jit = 0;

FOR ln IN

- EXECUTE format('explain (analyze %s, costs on, summary off, timing off) %s',

+ EXECUTE format('explain (analyze %s, costs on, summary off, timing off, buffers off) %s',

analyze_str, query)

LOOP

IF hide_costs = true THEN

diff --git a/src/test/regress/sql/matview.sql b/src/test/regress/sql/matview.sql

index b74ee305e0f6f1df264b1c7e7265879022dce444..6704eeae2df84d0b6743b9a0383572b083c42830 100644 (file)

--- a/src/test/regress/sql/matview.sql

+++ b/src/test/regress/sql/matview.sql

@@ -274,13 +274,13 @@ GRANT ALL ON SCHEMA matview_schema TO public;

SET SESSION AUTHORIZATION regress_matview_user;

CREATE MATERIALIZED VIEW matview_schema.mv_withdata1 (a) AS

SELECT generate_series(1, 10) WITH DATA;

-EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF)

+EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF)

CREATE MATERIALIZED VIEW matview_schema.mv_withdata2 (a) AS

SELECT generate_series(1, 10) WITH DATA;

REFRESH MATERIALIZED VIEW matview_schema.mv_withdata2;

CREATE MATERIALIZED VIEW matview_schema.mv_nodata1 (a) AS

SELECT generate_series(1, 10) WITH NO DATA;

-EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF)

+EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF)

CREATE MATERIALIZED VIEW matview_schema.mv_nodata2 (a) AS

SELECT generate_series(1, 10) WITH NO DATA;

REFRESH MATERIALIZED VIEW matview_schema.mv_nodata2;

@@ -301,16 +301,16 @@ CREATE MATERIALIZED VIEW matview_ine_tab AS

SELECT 1 / 0 WITH NO DATA; -- error

CREATE MATERIALIZED VIEW IF NOT EXISTS matview_ine_tab AS

SELECT 1 / 0 WITH NO DATA; -- ok

-EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF)

+EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF)

CREATE MATERIALIZED VIEW matview_ine_tab AS

SELECT 1 / 0; -- error

-EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF)

+EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF)

CREATE MATERIALIZED VIEW IF NOT EXISTS matview_ine_tab AS

SELECT 1 / 0; -- ok

-EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF)

+EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF)

CREATE MATERIALIZED VIEW matview_ine_tab AS

SELECT 1 / 0 WITH NO DATA; -- error

-EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF)

+EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF)

CREATE MATERIALIZED VIEW IF NOT EXISTS matview_ine_tab AS

SELECT 1 / 0 WITH NO DATA; -- ok

DROP MATERIALIZED VIEW matview_ine_tab;

diff --git a/src/test/regress/sql/misc_functions.sql b/src/test/regress/sql/misc_functions.sql

index 0a0c6e5a6bb796a703d8d52befcc74a76ebc3022..ac792abedf2d293d148cc052d12335c1aed0d39c 100644 (file)

--- a/src/test/regress/sql/misc_functions.sql

+++ b/src/test/regress/sql/misc_functions.sql

@@ -24,7 +24,7 @@ BEGIN

SET LOCAL jit = 0;

FOR ln IN

- EXECUTE format('explain (analyze %s, costs on, summary off, timing off) %s',

+ EXECUTE format('explain (analyze %s, costs on, summary off, timing off, buffers off) %s',

analyze_str, query)

LOOP

IF hide_costs = true THEN

This is the main PostgreSQL git repository.

RSS Atom