git.postgresql.org Git - postgresql.git/commitdiff

git projects / postgresql.git / commitdiff

Fix portability issue in pg_upgrade test script: avoid $PWD.

Tue, 7 Jul 2015 16:49:18 +0000 (12:49 -0400)

SUSv2-era shells don't set the PWD variable, though anything more modern
does. In the buildfarm environment this could lead to test.sh executing
with PWD pointing to $HOME or another high-level directory, so that there
were conflicts between concurrent executions of the test in different
branch subdirectories. This appears to be the explanation for recent
intermittent failures on buildfarm members binturong and dingo (and might
well have something to do with the buildfarm script's failure to capture
log files from pg_upgrade tests, too).

To fix, just use `pwd` in place of $PWD. AFAICS test.sh is the only place
in our source tree that depended on $PWD. Back-patch to all versions
containing this script.

Per buildfarm. Thanks to Oskari Saarenmaa for diagnosing the problem.

src/bin/pg_upgrade/test.sh patch | blob | blame | history

diff --git a/src/bin/pg_upgrade/test.sh b/src/bin/pg_upgrade/test.sh

index fef64dfb5f87a9f101bcf9251cdb4fda1c53717c..07002f6a1659a0256d783a7229569b5692ff096d 100644 (file)

--- a/src/bin/pg_upgrade/test.sh

+++ b/src/bin/pg_upgrade/test.sh

@@ -62,7 +62,8 @@ esac

POSTMASTER_OPTS="-F -c listen_addresses=$LISTEN_ADDRESSES -k \"$PGHOST\""

export PGHOST

-temp_root=$PWD/tmp_check

+# don't rely on $PWD here, as old shells don't set it

+temp_root=`pwd`/tmp_check

if [ "1ドル" = '--install' ]; then