git.postgresql.org Git - postgresql.git/commitdiff

git projects / postgresql.git / commitdiff

Fix bug in pairingheap_SpGistSearchItem_cmp()

author Alexander Korotkov <akorotkov@postgresql.org>

2019年9月24日 22:47:36 +0000 (01:47 +0300)

committer Alexander Korotkov <akorotkov@postgresql.org>

2019年9月24日 22:47:36 +0000 (01:47 +0300)

Our item contains only so->numberOfNonNullOrderBys of distances. Reflect that
in the loop upper bound.

Discussion: https://postgr.es/m/53536807-784c-e029-6e92-6da802ab8d60%40postgrespro.ru
Author: Nikita Glukhov
Backpatch-through: 12

src/backend/access/spgist/spgscan.c patch | blob | blame | history

diff --git a/src/backend/access/spgist/spgscan.c b/src/backend/access/spgist/spgscan.c

index cfba47067cc15f14cc0df0befe0fead35394d448..6e940fd3defdba1b7160d34cef28aa8929317fb9 100644 (file)

--- a/src/backend/access/spgist/spgscan.c

+++ b/src/backend/access/spgist/spgscan.c

@@ -56,7 +56,7 @@ pairingheap_SpGistSearchItem_cmp(const pairingheap_node *a,

else

{

/* Order according to distance comparison */

- for (i = 0; i < so->numberOfOrderBys; i++)

+ for (i = 0; i < so->numberOfNonNullOrderBys; i++)

{

if (isnan(sa->distances[i]) && isnan(sb->distances[i]))

continue; /* NaN == NaN */

This is the main PostgreSQL git repository.

RSS Atom