git.postgresql.org Git - postgresql.git/commitdiff

git projects / postgresql.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: fb1a188)
Update comments about index parallel builds
author Tomas Vondra <tomas.vondra@postgresql.org>
2024年12月17日 14:40:07 +0000 (15:40 +0100)
committer Tomas Vondra <tomas.vondra@postgresql.org>
2024年12月17日 14:40:07 +0000 (15:40 +0100)
Commit b43757171470 allowed parallel builds for BRIN, but left behind
two comments claiming only btree indexes support parallel builds.

Reported by Egor Rogov, along with similar issues in SGML docs.
Backpatch to 17, where parallel builds for BRIN were introduced.

Reported-by: Egor Rogov
Backpatch-through: 17
Discussion: https://postgr.es/m/114e2d5d-125e-07d8-94aa-5ad175fb7443@postgrespro.ru

src/backend/catalog/index.c patch | blob | blame | history
src/backend/optimizer/plan/planner.c patch | blob | blame | history

diff --git a/src/backend/catalog/index.c b/src/backend/catalog/index.c
index 1c3a9e06d37b9bfce737c3259c95d6dec14dc25a..05dc6add7eb7b4819545a143294af7b9630bec59 100644 (file)
--- a/src/backend/catalog/index.c
+++ b/src/backend/catalog/index.c
@@ -2989,7 +2989,7 @@ index_build(Relation heapRelation,
/*
* Determine worker process details for parallel CREATE INDEX. Currently,
- * only btree has support for parallel builds.
+ * only btree and BRIN have support for parallel builds.
*
* Note that planner considers parallel safety for us.
*/
diff --git a/src/backend/optimizer/plan/planner.c b/src/backend/optimizer/plan/planner.c
index a0a2de7ee4b67b7fbd4896b5b5509d194a2b9162..f3856c519f604f2c8c09e34fdaa1995564d4dc68 100644 (file)
--- a/src/backend/optimizer/plan/planner.c
+++ b/src/backend/optimizer/plan/planner.c
@@ -6758,7 +6758,8 @@ plan_cluster_use_sort(Oid tableOid, Oid indexOid)
* CREATE INDEX should request for use
*
* tableOid is the table on which the index is to be built. indexOid is the
- * OID of an index to be created or reindexed (which must be a btree index).
+ * OID of an index to be created or reindexed (which must be an index with
+ * support for parallel builds - currently btree or BRIN).
*
* Return value is the number of parallel worker processes to request. It
* may be unsafe to proceed if this is 0. Note that this does not include the
This is the main PostgreSQL git repository.
RSS Atom

AltStyle によって変換されたページ (->オリジナル) /