git.postgresql.org Git - postgresql.git/commitdiff

git projects / postgresql.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: a4f23f9)
Mark unsafe_tests module as not runnable with installcheck
author Andrew Dunstan <andrew@dunslane.net>
2023年3月12日 13:00:32 +0000 (09:00 -0400)
committer Andrew Dunstan <andrew@dunslane.net>
2023年3月12日 13:00:32 +0000 (09:00 -0400)
This was an omission in the original creation of the module.

Also slightly adjust some wording to avoid a double "is".

Backpatch the non-meson piece of this to release 12, where the module
was introduced.

Discussion: https://postgr.es/m/be869e1c-8e3f-4cde-8609-212c899cccf9@dunslane.net

src/test/modules/unsafe_tests/Makefile patch | blob | blame | history
src/test/modules/unsafe_tests/README patch | blob | blame | history
src/test/modules/unsafe_tests/meson.build patch | blob | blame | history

diff --git a/src/test/modules/unsafe_tests/Makefile b/src/test/modules/unsafe_tests/Makefile
index df582736884f0aa105c15e162b81951ebbd867ab..90d19791871c77dffbda5e0e0c9e218d289e6483 100644 (file)
--- a/src/test/modules/unsafe_tests/Makefile
+++ b/src/test/modules/unsafe_tests/Makefile
@@ -2,6 +2,9 @@
REGRESS = rolenames alter_system_table guc_privs
+# the whole point of these tests is to not run installcheck
+NO_INSTALLCHECK = 1
+
ifdef USE_PGXS
PG_CONFIG = pg_config
PGXS := $(shell $(PG_CONFIG) --pgxs)
diff --git a/src/test/modules/unsafe_tests/README b/src/test/modules/unsafe_tests/README
index a7e5b2a04f508e9c915167960e864be54e4f2f66..d9dbd038b9573960d6aaaafe32392d07a1e90c53 100644 (file)
--- a/src/test/modules/unsafe_tests/README
+++ b/src/test/modules/unsafe_tests/README
@@ -1,6 +1,6 @@
This directory doesn't actually contain any extension module.
-What it is is a home for regression tests that we don't want to run
+Instead it is a home for regression tests that we don't want to run
during "make installcheck" because they could have side-effects that
seem undesirable for a production installation.
diff --git a/src/test/modules/unsafe_tests/meson.build b/src/test/modules/unsafe_tests/meson.build
index 304f0ed61a2eb74d638e02fc9e7ab69d942ea906..b6806e4a0170c5afb62b71bed4bb09c881e8d270 100644 (file)
--- a/src/test/modules/unsafe_tests/meson.build
+++ b/src/test/modules/unsafe_tests/meson.build
@@ -10,5 +10,6 @@ tests += {
'alter_system_table',
'guc_privs',
],
+ 'runningcheck': false,
},
}
This is the main PostgreSQL git repository.
RSS Atom

AltStyle によって変換されたページ (->オリジナル) /