git.postgresql.org Git - postgresql.git/commitdiff

git projects / postgresql.git / commitdiff

Disallow deletion of CurrentExtensionObject while running extension script.

2011年11月29日 00:12:17 +0000 (19:12 -0500)

While the deletion in itself wouldn't break things, any further creation
of objects in the script would result in dangling pg_depend entries being
added by recordDependencyOnCurrentExtension(). An example from Phil
Sorber convinced me that this is just barely likely enough to be worth
expending a couple lines of code to defend against. The resulting error
message might be confusing, but it's better than leaving corrupted catalog
contents for the user to deal with.

src/backend/commands/extension.c patch | blob | blame | history

diff --git a/src/backend/commands/extension.c b/src/backend/commands/extension.c

index c334ca9cf8c5e287669a47702665cedb5b0677a2..7192c458e75188c312eb53773de8b50338e0d0d5 100644 (file)

--- a/src/backend/commands/extension.c

+++ b/src/backend/commands/extension.c

@@ -1577,6 +1577,23 @@ RemoveExtensionById(Oid extId)

HeapTuple tuple;

ScanKeyData entry[1];

+ /*

+ * Disallow deletion of any extension that's currently open for insertion;

+ * else subsequent executions of recordDependencyOnCurrentExtension()

+ * could create dangling pg_depend records that refer to a no-longer-valid