git.postgresql.org Git - postgresql.git/commitdiff

git projects / postgresql.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 9e3b3ff)
Update plannodes.h's comments about PlanRowMark.
Wed, 2 Jun 2021 15:52:35 +0000 (11:52 -0400)
Wed, 2 Jun 2021 15:52:35 +0000 (11:52 -0400)
The reference here to different physical column numbers in inherited
UPDATE/DELETE plans is obsolete as of 86dc90056; remove it. Also
rework the text about inheritance cases to make it clearer.


diff --git a/src/include/nodes/plannodes.h b/src/include/nodes/plannodes.h
index 57f320a1759ed9dd0d39ea3bccfc58386f9cd11a..aaa3b65d0492ff0c4e3dc8fab0b76dd9e53e4efe 100644 (file)
--- a/src/include/nodes/plannodes.h
+++ b/src/include/nodes/plannodes.h
@@ -1086,9 +1086,9 @@ typedef enum RowMarkType
* When the planner discovers that a relation is the root of an inheritance
* tree, it sets isParent true, and adds an additional PlanRowMark to the
* list for each child relation (including the target rel itself in its role
- * as a child). isParent is also set to true for the partitioned child
- * relations, which are not scanned just like the root parent. The child
- * entries have rti == child rel's RT index and prti == parent's RT index,
+ * as a child, if it is not a partitioned table). Any non-leaf partitioned
+ * child relations will also have entries with isParent = true. The child
+ * entries have rti == child rel's RT index and prti == top parent's RT index,
* and can therefore be recognized as children by the fact that prti != rti.
* The parent's allMarkTypes field gets the OR of (1<<markType) across all
* its children (this definition allows children to use different markTypes).
@@ -1109,8 +1109,7 @@ typedef enum RowMarkType
* means we needn't renumber rowmarkIds when flattening subqueries, which
* would require finding and renaming the resjunk columns as well.)
* Note this means that all tables in an inheritance hierarchy share the
- * same resjunk column names. However, in an inherited UPDATE/DELETE the
- * columns could have different physical column numbers in each subplan.
+ * same resjunk column names.
*/
typedef struct PlanRowMark
{
This is the main PostgreSQL git repository.
RSS Atom

AltStyle によって変換されたページ (->オリジナル) /