git.postgresql.org Git - postgresql.git/commitdiff

git projects / postgresql.git / commitdiff

author Thomas Munro <tmunro@postgresql.org>

Mon, 3 Aug 2020 00:39:15 +0000 (12:39 +1200)

committer Thomas Munro <tmunro@postgresql.org>

Mon, 3 Aug 2020 00:44:27 +0000 (12:44 +1200)

Instead of writing a query to psql's stdin, use -c. This avoids a
failure where psql exits before we write, seen a few times on the build
farm. Thanks to Tom Lane for the suggestion.

Back-patch to 11, where the LDAP tests arrived.

Reviewed-by: Noah Misch <noah@leadboat.com>
Discussion: https://postgr.es/m/CA%2BhUKGLFmW%2BHQYPeKiwSp5sdFFHtFViCpw4Mh6yAgEx74r5-Cw%40mail.gmail.com

src/test/ldap/t/001_auth.pl patch | blob | blame | history

diff --git a/src/test/ldap/t/001_auth.pl b/src/test/ldap/t/001_auth.pl

index f8941144f5e14e6f83a389480ea7c7e7df6016f3..3bc7672451ec88d8a39e42625079ab98b7b01c44 100644 (file)

--- a/src/test/ldap/t/001_auth.pl

+++ b/src/test/ldap/t/001_auth.pl

@@ -165,7 +165,8 @@ sub test_access

my ($node, $role, $expected_res, $test_name) = @_;

my $res =

- $node->psql('postgres', 'SELECT 1', extra_params => [ '-U', $role ]);

+ $node->psql('postgres', undef,

+ extra_params => [ '-U', $role, '-c', 'SELECT 1' ]);

is($res, $expected_res, $test_name);

return;

}

This is the main PostgreSQL git repository.

RSS Atom