git.postgresql.org Git - postgresql.git/commitdiff

git projects / postgresql.git / commitdiff

Fix pg_recvlogical avoidance of superfluous Standby Status Update.

2020年5月14日 03:42:09 +0000 (20:42 -0700)

committer Noah Misch <noah@leadboat.com>

2020年5月14日 03:42:24 +0000 (20:42 -0700)

The defect suppressed a Standby Status Update message when bytes flushed
to disk had changed but bytes received had not changed. If
pg_recvlogical then exited with no intervening Standby Status Update,
the next pg_recvlogical repeated already-flushed records. The defect
could also cause superfluous messages, which are functionally harmless.
Back-patch to 9.5 (all supported versions).

Discussion: https://postgr.es/m/20200502221647.GA3941274@rfd.leadboat.com

src/bin/pg_basebackup/pg_recvlogical.c patch | blob | blame | history

diff --git a/src/bin/pg_basebackup/pg_recvlogical.c b/src/bin/pg_basebackup/pg_recvlogical.c

index 679b901964be82d7bb4dc64756eb143810c69550..e153390f5e35899773b9a26018cd8f4d670fb381 100644 (file)

--- a/src/bin/pg_basebackup/pg_recvlogical.c

+++ b/src/bin/pg_basebackup/pg_recvlogical.c

@@ -128,7 +128,7 @@ sendFeedback(PGconn *conn, TimestampTz now, bool force, bool replyRequested)

if (!force &&

last_written_lsn == output_written_lsn &&

- last_fsync_lsn != output_fsync_lsn)

+ last_fsync_lsn == output_fsync_lsn)

return true;

if (verbose)

This is the main PostgreSQL git repository.

RSS Atom