git.postgresql.org Git - postgresql.git/commitdiff

git projects / postgresql.git / commitdiff

Fix rare core dump in BackendIdGetTransactionIds().

2015年3月30日 17:05:27 +0000 (13:05 -0400)

BackendIdGetTransactionIds() neglected the possibility that the PROC
pointer in a ProcState array entry is null. In current usage, this could
only crash if the other backend had exited since pgstat_read_current_status
saw it as active, which is a pretty narrow window. But it's reachable in
the field, per bug #12918 from Vladimir Borodin.

Back-patch to 9.4 where the faulty code was introduced.

src/backend/storage/ipc/sinvaladt.c patch | blob | blame | history

diff --git a/src/backend/storage/ipc/sinvaladt.c b/src/backend/storage/ipc/sinvaladt.c

index 81b85c0e42009b51ae5628a8ceaca5d919fe8f97..a2fde89b526b96e926b23f34a1092d77a3bb155b 100644 (file)

--- a/src/backend/storage/ipc/sinvaladt.c

+++ b/src/backend/storage/ipc/sinvaladt.c

@@ -403,9 +403,7 @@ BackendIdGetProc(int backendID)

void

BackendIdGetTransactionIds(int backendID, TransactionId *xid, TransactionId *xmin)

{

- ProcState *stateP;

SISeg *segP = shmInvalBuffer;

- PGXACT *xact;