git.postgresql.org Git - postgresql.git/commitdiff

git projects / postgresql.git / commitdiff

Fix race condition in drop subscription's handling of tablesync slots.

author Amit Kapila <akapila@postgresql.org>

2021年3月17日 02:45:12 +0000 (08:15 +0530)

committer Amit Kapila <akapila@postgresql.org>

2021年3月17日 02:45:12 +0000 (08:15 +0530)

Commit ce0fdbfe97 made tablesync slots permanent and allow Drop
Subscription to drop such slots. However, it is possible that before
tablesync worker could get the acknowledgment of slot creation, drop
subscription stops it and that can lead to a dangling slot on the
publisher. Prevent cancel/die interrupts while creating a slot in the
tablesync worker.

Reported-by: Thomas Munro as per buildfarm
Author: Amit Kapila
Reviewed-by: Vignesh C, Takamichi Osumi
Discussion: https://postgr.es/m/CA+hUKGJG9dWpw1cOQ2nzWU8PHjm=PTraB+KgE5648K9nTfwvxg@mail.gmail.com

src/backend/replication/logical/tablesync.c patch | blob | blame | history

diff --git a/src/backend/replication/logical/tablesync.c b/src/backend/replication/logical/tablesync.c

index feb634e7ac004a3fb16d70d5453e2d1bba10e4c8..6ed31812abc451f053a6a4a8c8c673aeca9e8ce8 100644 (file)

--- a/src/backend/replication/logical/tablesync.c

+++ b/src/backend/replication/logical/tablesync.c

@@ -1051,9 +1051,16 @@ LogicalRepSyncTableStart(XLogRecPtr *origin_startpos)

* Create a new permanent logical decoding slot. This slot will be used

* for the catchup phase after COPY is done, so tell it to use the

* snapshot to make the final data consistent.

+ *

+ * Prevent cancel/die interrupts while creating slot here because it is

+ * possible that before the server finishes this command, a concurrent