git.postgresql.org Git - postgresql.git/commitdiff

git projects / postgresql.git / commitdiff

Fix compilation warning with SerializeClientConnectionInfo()

author Michael Paquier <michael@paquier.xyz>

2025年8月14日 07:21:50 +0000 (16:21 +0900)

committer Michael Paquier <michael@paquier.xyz>

2025年8月14日 07:21:50 +0000 (16:21 +0900)

This function uses an argument named "maxsize" that is only used in
assertions, being set once outside the assertion area. Recent gcc
versions with -Wunused-but-set-parameter complain about a warning when
building without assertions enabled, because of that.

In order to fix this issue, PG_USED_FOR_ASSERTS_ONLY is added to the
function argument of SerializeClientConnectionInfo(), which is the first
time we are doing so in the tree. The CI is fine with the change, but
let's see what the buildfarm has to say on the matter.

Reviewed-by: Andres Freund <andres@anarazel.de>
Reviewed-by: Jacob Champion <jchampion@postgresql.org>
Discussion: https://postgr.es/m/pevajesswhxafjkivoq3yvwxga77tbncghlf3gq5fvchsvfuda@6uivg25sb3nx
Backpatch-through: 16

src/backend/utils/init/miscinit.c patch | blob | blame | history

diff --git a/src/backend/utils/init/miscinit.c b/src/backend/utils/init/miscinit.c

index 65d8cbfaed585289a824543de981585dd2e637d1..545d1e90fbd419ab6906a777100ed1b1ae906d19 100644 (file)

--- a/src/backend/utils/init/miscinit.c

+++ b/src/backend/utils/init/miscinit.c

@@ -1099,7 +1099,8 @@ EstimateClientConnectionInfoSpace(void)

* Serialize MyClientConnectionInfo for use by parallel workers.

void

-SerializeClientConnectionInfo(Size maxsize, char *start_address)

+SerializeClientConnectionInfo(Size maxsize PG_USED_FOR_ASSERTS_ONLY,

+ char *start_address)

{

SerializedClientConnectionInfo serialized = {0};

This is the main PostgreSQL git repository.

RSS Atom