git.postgresql.org Git - postgresql.git/commitdiff

git projects / postgresql.git / commitdiff

Remove contrib/jsonb_plpython's tests for infinity and NaN conversions.

Mon, 2 Apr 2018 16:36:21 +0000 (12:36 -0400)

These tests don't work reliably with pre-2.6 Python versions, since
Python code like float('inf') was not guaranteed to work before that,
even granting an IEEE-compliant platform.

Since there's no explicit handling of these cases in jsonb_plpython,
we're not adding any real code coverage by testing them, and thus
it doesn't seem to make sense to go to any great lengths to work
around the test instability.

Discussion: https://postgr.es/m/E1f1AMU-00031c-9N@gemulon.postgresql.org

contrib/jsonb_plpython/expected/jsonb_plpython.out patch | blob | blame | history

contrib/jsonb_plpython/sql/jsonb_plpython.sql patch | blob | blame | history

diff --git a/contrib/jsonb_plpython/expected/jsonb_plpython.out b/contrib/jsonb_plpython/expected/jsonb_plpython.out

index 22a7e53b69f88f2a4eb32276559f2d5a163d3e22..b491fe9cc68d7ca0b07b18dd3d7d50764685675c 100644 (file)

--- a/contrib/jsonb_plpython/expected/jsonb_plpython.out

+++ b/contrib/jsonb_plpython/expected/jsonb_plpython.out

@@ -236,46 +236,6 @@ SELECT roundtrip('["string", "string2"]'::jsonb);

["string", "string2"]

(1 row)

--- test python infinity -> jsonb

-CREATE FUNCTION test1inf() RETURNS jsonb

-LANGUAGE plpythonu

-TRANSFORM FOR TYPE jsonb

-AS $$

-x = float('inf')

-print(x)

-return x

-$$;

-SELECT test1inf();

-ERROR: could not convert value "inf" to jsonb

-CONTEXT: while creating return value

-PL/Python function "test1inf"

--- test python -infinity -> jsonb

-CREATE FUNCTION test2inf() RETURNS jsonb

-LANGUAGE plpythonu

-TRANSFORM FOR TYPE jsonb

-AS $$

-x = float('-inf')

-print(x)

-return x

-$$;

-SELECT test2inf();

-ERROR: could not convert value "-inf" to jsonb

-CONTEXT: while creating return value

-PL/Python function "test2inf"

--- test python NaN -> jsonb

-CREATE FUNCTION test1nan() RETURNS jsonb

-LANGUAGE plpythonu

-TRANSFORM FOR TYPE jsonb

-AS $$

-x = float('nan')

-return x

-$$;

-SELECT test1nan();

- test1nan

-----------

- NaN

-(1 row)

-- complex numbers -> jsonb

CREATE FUNCTION testComplexNumbers() RETURNS jsonb

LANGUAGE plpythonu

diff --git a/contrib/jsonb_plpython/sql/jsonb_plpython.sql b/contrib/jsonb_plpython/sql/jsonb_plpython.sql

index b4b0820afe637ddb5038cafc14216dff0d71329d..2ee1bca0a980076f1232340f0ae6fa47e9bbefa7 100644 (file)

--- a/contrib/jsonb_plpython/sql/jsonb_plpython.sql

+++ b/contrib/jsonb_plpython/sql/jsonb_plpython.sql

@@ -127,41 +127,6 @@ SELECT roundtrip('[1, true]'::jsonb);

SELECT roundtrip('[true, "string"]'::jsonb);

SELECT roundtrip('["string", "string2"]'::jsonb);

--- test python infinity -> jsonb

-CREATE FUNCTION test1inf() RETURNS jsonb

-LANGUAGE plpythonu

-TRANSFORM FOR TYPE jsonb

-AS $$

-x = float('inf')

-print(x)

-return x

-$$;

-SELECT test1inf();

--- test python -infinity -> jsonb

-CREATE FUNCTION test2inf() RETURNS jsonb

-LANGUAGE plpythonu

-TRANSFORM FOR TYPE jsonb

-AS $$

-x = float('-inf')

-print(x)

-return x

-$$;

-SELECT test2inf();

--- test python NaN -> jsonb

-CREATE FUNCTION test1nan() RETURNS jsonb

-LANGUAGE plpythonu

-TRANSFORM FOR TYPE jsonb

-AS $$

-x = float('nan')

-return x

-$$;

-SELECT test1nan();

-- complex numbers -> jsonb

CREATE FUNCTION testComplexNumbers() RETURNS jsonb

LANGUAGE plpythonu

This is the main PostgreSQL git repository.

RSS Atom