git.postgresql.org Git - postgresql.git/commitdiff

git projects / postgresql.git / commitdiff

Don't release index root page pin in ginFindParents().

2023年11月13日 16:44:35 +0000 (11:44 -0500)

It's clearly stated in the comments that ginFindParents() must keep
the pin on the index's root page that's associated with the topmost
GinBtreeStack item. However, the code path for the case that the
desired downlink has been pushed down to the next index level
ignored this proviso, and would release the pin anyway if we were
still examining the root level. That led to an assertion failure
or "buffer NNNN is not owned by resource owner" error later, when
we try to release the pin again at the end of the insertion.

This is quite hard to reproduce, since it can only happen if an
index root page split occurs concurrently with our own insertion.
Thanks to Jeff Janes for finding a test case that triggers it
often enough to allow investigation.

This has been there since the beginning of GIN, so back-patch
to all supported branches.

Discussion: https://postgr.es/m/CAMkU=1yCAKtv86dMrD__Ja-7KzjE=uMeKX8y__cx5W-OEWy2ow@mail.gmail.com

src/backend/access/gin/ginbtree.c patch | blob | blame | history

diff --git a/src/backend/access/gin/ginbtree.c b/src/backend/access/gin/ginbtree.c

index fc694b40f142116544e80dab8d7564c8c1e4d508..a8e46dfd8c2077c0d364bf2b35a3fd5f46f39131 100644 (file)

--- a/src/backend/access/gin/ginbtree.c

+++ b/src/backend/access/gin/ginbtree.c

@@ -272,7 +272,11 @@ ginFindParents(GinBtree btree, GinBtreeStack *stack)

blkno = GinPageGetOpaque(page)->rightlink;

if (blkno == InvalidBlockNumber)

{

- UnlockReleaseBuffer(buffer);

+ /* Link not present in this level */

+ LockBuffer(buffer, GIN_UNLOCK);