git.postgresql.org Git - postgresql.git/commitdiff

git projects / postgresql.git / commitdiff

Remove dead assignment to local variable.

author Heikki Linnakangas <heikki.linnakangas@iki.fi>

2021年7月12日 08:13:33 +0000 (11:13 +0300)

committer Heikki Linnakangas <heikki.linnakangas@iki.fi>

2021年7月12日 08:13:33 +0000 (11:13 +0300)

This should have been removed in commit 7e30c186da, which split the loop
into two. Only the first loop uses the 'from' variable; updating it in
the second loop is bogus. It was never read after the first loop, so this
was harmless and surely optimized away by the compiler, but let's be tidy.

Backpatch to all supported versions.

Author: Ranier Vilela
Discussion: https://www.postgresql.org/message-id/CAEudQAoWq%2BAL3BnELHu7gms2GN07k-np6yLbukGaxJ1vY-zeiQ%40mail.gmail.com

src/backend/access/nbtree/nbtxlog.c patch | blob | blame | history

diff --git a/src/backend/access/nbtree/nbtxlog.c b/src/backend/access/nbtree/nbtxlog.c

index c2e920f159ccbd229e01d643b17f0a942aa0c85e..786c08c0cea8a201d68fcfcc58f4864a678bf25f 100644 (file)

--- a/src/backend/access/nbtree/nbtxlog.c

+++ b/src/backend/access/nbtree/nbtxlog.c

@@ -77,7 +77,6 @@ _bt_restore_page(Page page, char *from, int len)

if (PageAddItem(page, items[i], itemsizes[i], nitems - i,

false, false) == InvalidOffsetNumber)

elog(PANIC, "_bt_restore_page: cannot add item to page");

- from += itemsz;

}

This is the main PostgreSQL git repository.

RSS Atom