git.postgresql.org Git - postgresql.git/commitdiff

git projects / postgresql.git / commitdiff

Remove the flaky check in event_trigger_login regression test

author Alexander Korotkov <akorotkov@postgresql.org>

2024年1月17日 21:16:53 +0000 (23:16 +0200)

committer Alexander Korotkov <akorotkov@postgresql.org>

2024年1月17日 21:16:53 +0000 (23:16 +0200)

The query checks that pg_database.dathasloginevt is unset on connect when
there are no event triggers. However, unsetting this flag is implemented in
a non-blocking way, so a concurrent autovacuum connection breaks this check.
It doesn't seem we can do much with this, at least within a regression test.
So, remove it.

Reported-by: Alexander Lakhin
Discussion: https://postgr.es/m/44807d19-81a6-3884-3e0f-22dd99aac3ed%40gmail.com

src/test/regress/expected/event_trigger_login.out patch | blob | blame | history

src/test/regress/sql/event_trigger_login.sql patch | blob | blame | history

diff --git a/src/test/regress/expected/event_trigger_login.out b/src/test/regress/expected/event_trigger_login.out

index 174879578be9e400ddf9d7eb9d9e8c36c57512a4..4f43c2352f6a879c1c692d1586b6f72deca393c9 100644 (file)

--- a/src/test/regress/expected/event_trigger_login.out

+++ b/src/test/regress/expected/event_trigger_login.out

@@ -37,9 +37,3 @@ DROP TABLE user_logins;

DROP EVENT TRIGGER on_login_trigger;

DROP FUNCTION on_login_proc();

-SELECT dathasloginevt FROM pg_database WHERE datname= :'DBNAME';

- dathasloginevt

-----------------