git.postgresql.org Git - postgresql.git/commitdiff

git projects / postgresql.git / commitdiff

Fix some problems with patch to fsync the data directory.

author Robert Haas <rhaas@postgresql.org>

Tue, 5 May 2015 12:30:28 +0000 (08:30 -0400)

committer Robert Haas <rhaas@postgresql.org>

Tue, 5 May 2015 13:29:49 +0000 (09:29 -0400)

pg_win32_is_junction() was a typo for pgwin32_is_junction(). open()
was used not only in a two-argument form, which breaks on Windows,
but also where BasicOpenFile() should have been used.

Per reports from Andrew Dunstan and David Rowley.

src/backend/storage/file/fd.c patch | blob | blame | history

diff --git a/src/backend/storage/file/fd.c b/src/backend/storage/file/fd.c

index 99dac841ffa5f2f349db897406d91b7512b2548a..6fa75d18d30521ad4f931ad1751eedd13ac5dffb 100644 (file)

--- a/src/backend/storage/file/fd.c

+++ b/src/backend/storage/file/fd.c

@@ -2450,7 +2450,7 @@ pre_sync_fname(char *fname, bool isdir)

{

int fd;

- fd = open(fname, O_RDONLY | PG_BINARY);

+ fd = BasicOpenFile(fname, O_RDONLY | PG_BINARY, 0);

* Some OSs don't allow us to open directories at all (Windows returns

@@ -2509,7 +2509,7 @@ walkdir(char *path, void (*action) (char *fname, bool isdir))

#ifndef WIN32

else if (S_ISLNK(fst.st_mode))

#else

- else if (pg_win32_is_junction(subpath))

+ else if (pgwin32_is_junction(subpath))

#endif

{

#if defined(HAVE_READLINK) || defined(WIN32)

This is the main PostgreSQL git repository.

RSS Atom