git.postgresql.org Git - postgresql.git/commitdiff

git projects / postgresql.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: a9f0dbc)
In pg_upgrade, add C comment about why we don't try to do shared file
2011年7月21日 21:12:35 +0000 (17:12 -0400)
2011年7月21日 21:13:17 +0000 (17:13 -0400)
writes for logging.


diff --git a/contrib/pg_upgrade/pg_upgrade.h b/contrib/pg_upgrade/pg_upgrade.h
index df884bd684b6f4cbf0a2ab9cdecd6da28f738f60..6def748ae81f796e2053e520a5718d6dd7f3d7f3 100644 (file)
--- a/contrib/pg_upgrade/pg_upgrade.h
+++ b/contrib/pg_upgrade/pg_upgrade.h
@@ -207,6 +207,10 @@ typedef struct
* because it is being used by another process." so we have to send all
* other output to 'nul'. Therefore, we set this to DEVNULL on Win32, and
* it equals 'filename' on all other platforms.
+ *
+ * We could use the Windows pgwin32_open() flags to allow shared file
+ * writes but is unclear how all other tools would use those flags, so
+ * we just avoid it and log a little less on Windows.
*/
char *filename2;
FILE *fd; /* log FILE */
This is the main PostgreSQL git repository.
RSS Atom

AltStyle によって変換されたページ (->オリジナル) /