git.postgresql.org Git - postgresql.git/commitdiff

git projects / postgresql.git / commitdiff

Tweak description comments in tests for partition functions

author Michael Paquier <michael@paquier.xyz>

2018年12月18日 01:52:21 +0000 (10:52 +0900)

committer Michael Paquier <michael@paquier.xyz>

2018年12月18日 01:52:21 +0000 (10:52 +0900)

The new wording is more generic and fixes one grammar mistake and one
typo on the way.

Per discussion between Amit Langote and me.

Discussion: https://postgr.es/m/20181217064028.GJ31474@paquier.xyz

src/test/regress/expected/partition_info.out patch | blob | blame | history

src/test/regress/sql/partition_info.sql patch | blob | blame | history

diff --git a/src/test/regress/expected/partition_info.out b/src/test/regress/expected/partition_info.out

index 202d8208279a49b235d507b84eb211784dd44718..3e15e02f8da6e1b15b4706ed427cf53e7fd80ed3 100644 (file)

--- a/src/test/regress/expected/partition_info.out

+++ b/src/test/regress/expected/partition_info.out

@@ -1,5 +1,5 @@

--- Tests for pg_partition_tree

+-- Tests for functions providing information about partitions

SELECT * FROM pg_partition_tree(NULL);

relid | parentrelid | isleaf | level

@@ -99,7 +99,7 @@ SELECT relid, parentrelid, level, isleaf

(1 row)

DROP TABLE ptif_test;

--- A table not part of a partition tree works is the only member listed.

+-- Table that is not part of any partition tree is the only member listed.

CREATE TABLE ptif_normal_table(a int);

SELECT relid, parentrelid, level, isleaf

FROM pg_partition_tree('ptif_normal_table');

@@ -109,7 +109,9 @@ SELECT relid, parentrelid, level, isleaf

(1 row)

DROP TABLE ptif_normal_table;

--- Views and materialized viewS cannot be part of a partition tree.

+-- Various partitioning-related functions return NULL if passed relations

+-- of types that cannot be part of a partition tree; for example, views,

+-- materialized views, etc.

CREATE VIEW ptif_test_view AS SELECT 1;

CREATE MATERIALIZED VIEW ptif_test_matview AS SELECT 1;

SELECT * FROM pg_partition_tree('ptif_test_view');

diff --git a/src/test/regress/sql/partition_info.sql b/src/test/regress/sql/partition_info.sql

index 9b55a7fe5cee82a656f044f96bad311abba1a39f..5d6e647146df65040ccf1fac81a40190b524a856 100644 (file)

--- a/src/test/regress/sql/partition_info.sql

+++ b/src/test/regress/sql/partition_info.sql