git.postgresql.org Git - postgresql.git/commitdiff

git projects / postgresql.git / commitdiff

injection_points: Fix incrementation of variable-numbered stats

author Michael Paquier <michael@paquier.xyz>

2025年9月17日 01:15:13 +0000 (10:15 +0900)

committer Michael Paquier <michael@paquier.xyz>

2025年9月17日 01:15:13 +0000 (10:15 +0900)

The pending entry was not used when incrementing its data, directly
manipulating the shared memory pointer, without even locking it. This
could mean losing statistics under concurrent activity. The flush
callback was a no-op.

This code serves as a base template for extensions for the custom
cumulative statistics, so let's be clean and use a pending entry for the
incrementations, whose data is then flushed to the corresponding entry
in the shared hashtable when all the stats are reported, in its own
flush callback.

Author: Sami Imseih <samimseih@gmail.com>
Discussion: https://postgr.es/m/CAA5RZ0v0U0yhPbY+bqChomkPbyUrRQ3rQXnZf_SB-svDiQOpgQ@mail.gmail.com
Backpatch-through: 18

src/test/modules/injection_points/injection_stats.c patch | blob | blame | history

diff --git a/src/test/modules/injection_points/injection_stats.c b/src/test/modules/injection_points/injection_stats.c

index e3947b23ba57330d5a3339396da0a9a0cc5e8f2f..ca8df4ad217ab91fc5dbf18665135ced42d8cc84 100644 (file)

--- a/src/test/modules/injection_points/injection_stats.c

+++ b/src/test/modules/injection_points/injection_stats.c

@@ -164,8 +164,7 @@ void

pgstat_report_inj(const char *name)

{

PgStat_EntryRef *entry_ref;

- PgStatShared_InjectionPoint *shstatent;

- PgStat_StatInjEntry *statent;

+ PgStat_StatInjEntry *pending;