git.postgresql.org Git - postgresql.git/commitdiff

git projects / postgresql.git / commitdiff

Add explicit initialization for all PlannerGlobal fields

author Richard Guo <rguo@postgresql.org>

2025年5月14日 00:59:31 +0000 (09:59 +0900)

committer Richard Guo <rguo@postgresql.org>

2025年5月14日 00:59:31 +0000 (09:59 +0900)

When creating a new PlannerGlobal node in standard_planner(), most
fields are explicitly initialized, but a few are not. This doesn't
cause any functional issues, as makeNode() zeroes all fields by
default. However, the inconsistency is undesirable from a clarity and
maintenance perspective.

This patch explicitly initializes the remaining fields to improve
consistency and readability.

Author: Richard Guo <guofenglinux@gmail.com>
Reviewed-by: David Rowley <dgrowleyml@gmail.com>
Discussion: https://postgr.es/m/CAMbWs4-TgQHNOiouqGcuHoBqbJjWyx4UxGKxUY3FrF4trGbcPA@mail.gmail.com

src/backend/optimizer/plan/planner.c patch | blob | blame | history

diff --git a/src/backend/optimizer/plan/planner.c b/src/backend/optimizer/plan/planner.c

index beafac8c0b04e8a27c074eb928605c63717c96fe..49ad6e835782fd87e6a7fdacd4633433c9f6955b 100644 (file)

--- a/src/backend/optimizer/plan/planner.c

+++ b/src/backend/optimizer/plan/planner.c

@@ -326,10 +326,14 @@ standard_planner(Query *parse, const char *query_string, int cursorOptions,

glob->subroots = NIL;

glob->rewindPlanIDs = NULL;

glob->finalrtable = NIL;

+ glob->allRelids = NULL;

+ glob->prunableRelids = NULL;

glob->finalrteperminfos = NIL;