git.postgresql.org Git - postgresql.git/commitdiff

git projects / postgresql.git / commitdiff

Suppress occasional failures in brin regression test.

2015年5月26日 18:10:46 +0000 (14:10 -0400)

2015年5月26日 18:11:12 +0000 (14:11 -0400)

brin.sql included a call of brin_summarize_new_values(), and expected
it to always report exactly 5 summarization events. This failed sometimes
during parallel regression tests, as a consequence of the database-wide
VACUUM in gist.sql getting there first. The most future-proof way
to avoid variation in the test results is to forget about using
brin_summarize_new_values() and just do a plain "VACUUM brintest",
which will exercise the same code anyway.

Having done that, there's no need for preventing autovacuum on brintest;
doing so just reduces the scope of test coverage, so let's not.

src/test/regress/expected/brin.out patch | blob | blame | history

src/test/regress/sql/brin.sql patch | blob | blame | history

diff --git a/src/test/regress/expected/brin.out b/src/test/regress/expected/brin.out

index 8ba961a662b325ead7b589334f562edb9498129f..2be4b7ca3f6fb6d8c1f8b8f6a9b098044779a39e 100644 (file)

--- a/src/test/regress/expected/brin.out

+++ b/src/test/regress/expected/brin.out

@@ -26,7 +26,7 @@ CREATE TABLE brintest (byteacol bytea,

int4rangecol int4range,

lsncol pg_lsn,

boxcol box

-) WITH (fillfactor=10, autovacuum_enabled=off);

+) WITH (fillfactor=10);