git.postgresql.org Git - postgresql.git/commitdiff

git projects / postgresql.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: f5a5773)
Fix recovery test hang in 021_row_visibility.pl on windows.
Mon, 1 Mar 2021 17:52:15 +0000 (09:52 -0800)
Mon, 1 Mar 2021 19:25:24 +0000 (11:25 -0800)
The psql processes were not explicitly killed (but would eventually
exit due postgres shutting down). For some reason windows perl doesn't
like that, resulting in errors like
Warning: unable to close filehandle GEN20 properly: Bad file descriptor during global destruction.

The test was introduced in d6734a897e3, so no backpatching necessary.


diff --git a/src/test/recovery/t/021_row_visibility.pl b/src/test/recovery/t/021_row_visibility.pl
index fac6646a872fe238717d7618ea59492cd3cd77dd..b76990dfe05c8e87f93b31787ee1ec77a3d8e7e2 100644 (file)
--- a/src/test/recovery/t/021_row_visibility.pl
+++ b/src/test/recovery/t/021_row_visibility.pl
@@ -151,6 +151,10 @@ ok(send_query_and_wait(\%psql_standby,
qr/will_commit.*\n\(1 row\)$/m),
'finished prepared visible');
+# explicitly shut down psql instances - they cause hangs on windows
+$psql_primary{run}->kill_kill;
+$psql_standby{run}->kill_kill;
+
$node_primary->stop;
$node_standby->stop;
This is the main PostgreSQL git repository.
RSS Atom

AltStyle によって変換されたページ (->オリジナル) /