git.postgresql.org Git - postgresql.git/commitdiff

git projects / postgresql.git / commitdiff

Sun, 9 Aug 2020 15:32:31 +0000 (11:32 -0400)

Testing that an unsigned variable is >= 0 is pretty pointless,
as noted by Coverity and numerous buildfarm members.

In passing, add comment about new uses of "volatile" --- Coverity
doesn't much like that either, but it seems probably necessary.

src/backend/replication/logical/reorderbuffer.c patch | blob | blame | history

diff --git a/src/backend/replication/logical/reorderbuffer.c b/src/backend/replication/logical/reorderbuffer.c

index 5b7afe6d9e9cfd6222e7aa74a29115684811b72f..1975d629a6e2f025f041d0ad23d28dc7dbd95fba 100644 (file)

--- a/src/backend/replication/logical/reorderbuffer.c

+++ b/src/backend/replication/logical/reorderbuffer.c

@@ -1907,6 +1907,9 @@ ReorderBufferResetTXN(ReorderBuffer *rb, ReorderBufferTXN *txn,

* merge) and replay the changes in lsn order.

* If streaming is true then data will be sent using stream API.

+ *

+ * Note: "volatile" markers on some parameters are to avoid trouble with

+ * PG_TRY inside the function.

static void

ReorderBufferProcessTXN(ReorderBuffer *rb, ReorderBufferTXN *txn,

@@ -2762,7 +2765,6 @@ ReorderBufferChangeMemoryUpdate(ReorderBuffer *rb,

}

Assert(txn->size <= rb->size);

- Assert((txn->size >= 0) && (rb->size >= 0));

}

This is the main PostgreSQL git repository.

RSS Atom