git.postgresql.org Git - postgresql.git/commitdiff

git projects / postgresql.git / commitdiff

Fix possible page corruption by ALTER TABLE .. SET TABLESPACE.

author Robert Haas <rhaas@postgresql.org>

2010年7月29日 16:14:36 +0000 (16:14 +0000)

committer Robert Haas <rhaas@postgresql.org>

2010年7月29日 16:14:36 +0000 (16:14 +0000)

If a zeroed page is present in the heap, ALTER TABLE .. SET TABLESPACE will
set the LSN and TLI while copying it, which is wrong, and heap_xlog_newpage()
will do the same thing during replay, so the corruption propagates to any
standby. Note, however, that the bug can't be demonstrated unless archiving
is enabled, since in that case we skip WAL logging altogether, and the LSN/TLI
are not set.

Back-patch to 8.0; prior releases do not have tablespaces.

Analysis and patch by Jeff Davis. Adjustments for back-branches and minor
wordsmithing by me.

src/backend/access/heap/heapam.c patch | blob | blame | history

diff --git a/src/backend/access/heap/heapam.c b/src/backend/access/heap/heapam.c

index e17b6362c312890e72c734ed5517756874abf2b3..5eebfbc28f946dc80330a48197bfa46455270cf9 100644 (file)

--- a/src/backend/access/heap/heapam.c

+++ b/src/backend/access/heap/heapam.c

@@ -8,7 +8,7 @@

* IDENTIFICATION

- * $PostgreSQL: pgsql/src/backend/access/heap/heapam.c,v 1.292 2010年07月06日 19:18:55 momjian Exp $

+ * $PostgreSQL: pgsql/src/backend/access/heap/heapam.c,v 1.293 2010年07月29日 16:14:36 rhaas Exp $

* INTERFACE ROUTINES

@@ -4079,8 +4079,15 @@ log_newpage(RelFileNode *rnode, ForkNumber forkNum, BlockNumber blkno,

recptr = XLogInsert(RM_HEAP_ID, XLOG_HEAP_NEWPAGE, rdata);

- PageSetLSN(page, recptr);

- PageSetTLI(page, ThisTimeLineID);

+ /*

+ * The page may be uninitialized. If so, we can't set the LSN

+ * and TLI because that would corrupt the page.

+ */

+ if (!PageIsNew(page))

+ {

+ PageSetLSN(page, recptr);

+ PageSetTLI(page, ThisTimeLineID);

+ }

END_CRIT_SECTION();

@@ -4266,8 +4273,16 @@ heap_xlog_newpage(XLogRecPtr lsn, XLogRecord *record)

Assert(record->xl_len == SizeOfHeapNewpage + BLCKSZ);

memcpy(page, (char *) xlrec + SizeOfHeapNewpage, BLCKSZ);

- PageSetLSN(page, lsn);

- PageSetTLI(page, ThisTimeLineID);

+ /*

+ * The page may be uninitialized. If so, we can't set the LSN

+ * and TLI because that would corrupt the page.

+ */

+ if (!PageIsNew(page))

+ {

+ PageSetLSN(page, lsn);

+ PageSetTLI(page, ThisTimeLineID);

+ }

MarkBufferDirty(buffer);

UnlockReleaseBuffer(buffer);

}

This is the main PostgreSQL git repository.

RSS Atom